GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102509: Ignore acceptable access of an uninitialized value by illia-v · Pull Request #102838 · python/cpython

Conversation

@illia-v

@illia-v illia-v commented Mar 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is done to ignore an error on accessing an uninitialized integer without an adverse effect.
#102509 (comment)

  • Issue: cpython3:fuzz_builtin_unicode: Use-of-uninitialized-value in maybe_small_long #102509

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@illia-v
pythongh-102509: Create an ignore list for sanitizers
6a0ff63
@illia-v
illia-v requested review from corona10 and erlend-aasland as code owners March 20, 2023 07:39
@bedevere-bot bedevere-bot mentioned this pull request Mar 20, 2023
cpython3:fuzz_builtin_unicode: Use-of-uninitialized-value in maybe_small_long #102509
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 20, 2023
@illia-v
Add a news entry
01b6e1d
@illia-v illia-v changed the title gh-102509: Create an ignore list for sanitizers gh-102509: Ignore acceptable access of an uninitialized value Mar 20, 2023
@erlend-aasland

erlend-aasland commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

AFAICS, this is an alternative to #102510. Let's wait an see what the Marks decide over there first.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland marked this pull request as draft March 22, 2023 10:02
@erlend-aasland
erlend-aasland removed their request for review May 8, 2023 07:55
@arhadthedev

arhadthedev commented May 11, 2023

Copy link
Copy Markdown
Member

Let's wait an see what the Marks decide over there first.

@mdickinson
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@illia-v
Merge branch 'main' into pythongh-102509-ignorelist
30bd44c
@illia-v

illia-v commented May 17, 2023

Copy link
Copy Markdown
Contributor Author

It will be nice to have the error fixed in the first beta of 3.12.

I've just checked that #101291 has not affected the use of the uninitialized value yet (see #102510 (comment) for previous expectations) and running CC=clang ./configure --with-memory-sanitizer && make -j12 still fails without the patch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdickinson

mdickinson commented May 20, 2023

Copy link
Copy Markdown
Member

@arhadthedev

@mdickinson

I think this one's for @markshannon to decide; he has better awareness of the #102510 performance trade-offs than I do. (And it's "his" code, in some sense.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@illia-v

illia-v commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

Closing this because the value was initialized explicitly in #102510 and #107464
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@illia-v illia-v closed this Jul 31, 2023
@illia-v
illia-v deleted the gh-102509-ignorelist branch July 31, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@illia-v @erlend-aasland @arhadthedev @mdickinson @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.