GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100227: Make the Global Interned Dict Safe for Isolated Interpreters by ericsnowcurrently · Pull Request #102858 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Mar 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is an alternative to gh-102339, where we keep the interned dict global instead of making it per-interpreter.

  • Issue: Improve Interpreter Isolation #100227

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 9 commits March 20, 2023 14:03
@ericsnowcurrently
Initialize the interned dict in _PyUnicode_InitGlobalObjects().
9420a1c
@ericsnowcurrently
Add some TODO comments.
cca77b9
@ericsnowcurrently
Factor out store_interned().
fa3974f
@ericsnowcurrently
Store a thread state to use just for interned strings.
eadd48a
@ericsnowcurrently
Always use the main interpreter when possibly resizing the interned d…
5d6e1b9 
…ict.
@ericsnowcurrently
Make interned strings immortal.
16ed5e0
@ericsnowcurrently
Temporarily skip immortalizing.
d36f119
@ericsnowcurrently
Add the mutex for the interned dict.
6d5f129
@ericsnowcurrently
Lock around store_interned().
b634920
@ericsnowcurrently ericsnowcurrently added the skip news label Mar 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 20, 2023
Improve Interpreter Isolation #100227
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 20, 2023
@ericsnowcurrently
ericsnowcurrently requested a review from kumaraditya303 March 20, 2023 23:12
This was referenced Mar 20, 2023
gh-100227: Move the Dict of Interned Strings to PyInterpreterState #102339
Merged
gh-84436: Make Interned Strings Immortal #102887
Closed
@ericsnowcurrently

ericsnowcurrently commented Mar 21, 2023

Copy link
Copy Markdown
Member Author

We make the interned strings immortal separately in gh-102887.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented Mar 22, 2023

Copy link
Copy Markdown
Member Author

This is superceded by gh-102925, except for the part where we add a granular lock, which would need to be taken care of for a per-interpreter GIL.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently closed this Mar 22, 2023
@ericsnowcurrently
ericsnowcurrently deleted the make-global-interned-dict-safe branch March 22, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity will be requested when the pull request is marked ready for review ZeroIntensity is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.