GeezerVison is showing github.com — [WIP] GH-89727: Fix `shutil.rmtree()` recursion error on deep trees. by barneygale · Pull Request #103164 · python/cpython
Conversation
barneygale
commented
Apr 1, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Add a follow_junctions argument to pathlib.Path.walk(). When set to false, directory junctions are treated as files.
Add an _fwalk() method to pathlib.Path, similar to os.fwalk() except in its treatment of symlinks.
(This method could be made public in future if desired).
Implement shutil.rmtree() using pathlib.Path.walk() or _fwalk().
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add a `follow_junctions` argument to `pathlib.Path.walk()`. When set to
false, directory junctions are treated as files.
Add an `fwalk()` method to `pathlib.Path`, analogous to `os.fwalk()`.
Implement `shutil.rmtree()` using `pathlib.Path.walk()` and `fwalk()`.
Uh oh!
There was an error while loading. Please reload this page.
|
Withdrawing this PR - it's out of date, and I'd like to keep the Path API stable until PathBase is made public (see #110109)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
giampaolo
Awaiting requested review from giampaolo
giampaolo will be requested when the pull request is marked ready for review
giampaolo is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.