GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — gh-103053: Skip the whole `test_freeze` module in tests on `s390x` with `PGO` by sobolevn · Pull Request #103170 · python/cpython Conversation
|
|
🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 74ded76 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @sobolevn for commit ee8f33c 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 9b2a4c3 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @sobolevn for commit be3e15d 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
test_freeze module in tests on buildbotstest_freeze module in tests on s390x with PGO
|
@zware can you please take a look when you have the time? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Please don't do that. It's ok to have a red buildbot, it doesn't prevent to release Python: it's only part of PEP 11 Tier 3.
Failures on these platforms do not block a release.
If you skip the failing test, as the maintainer of this platform, I will no be able to notice it :-(
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
So, other options are:
Any ideas are welcome! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
We can try with a greatly increased timeout for this particular platform and see if that's indeed the problem. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Use a subdirectory in the build area, instead of |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Honestly, I'm not convinced by the value of this test. If freeze is badly broken, everybody will notice since Python itself is also frozen, no? Or did I misunderstood the purpose of the test, or what's frozen exactly? Don't all core devs already indirectly test frozen Python? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I wrote PR #109591 to not skip the test on s390x, but only if Python is built with PGO, which is differerent. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.