GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103053: Skip the whole `test_freeze` module in tests on `s390x` with `PGO` by sobolevn · Pull Request #103170 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Apr 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Now, let's try the buildbot test with these changes.

  • Issue: test_tools: test_freeze_simple_script() times out after 15 min: --with-lto --enable-optimizations (s390x LTO buildbots) #103053

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting review label Apr 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 1, 2023
test_tools: test_freeze_simple_script() times out after 15 min: --with-lto --enable-optimizations (s390x LTO buildbots) #103053
Closed
@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2023
@bedevere-bot

bedevere-bot commented Apr 1, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 74ded76 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2023
@sobolevn sobolevn added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 1, 2023
@bedevere-bot

bedevere-bot commented Apr 1, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit ee8f33c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2023
@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 6, 2023
@bedevere-bot

bedevere-bot commented Apr 6, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 9b2a4c3 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 6, 2023
@sobolevn
pythongh-103053: Skip test_tools on s390x and with PGO enabled
be3e15d
@sobolevn
sobolevn force-pushed the issue-103053 branch from 9b2a4c3 to be3e15d Compare April 6, 2023 17:49
@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 6, 2023
@bedevere-bot

bedevere-bot commented Apr 6, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit be3e15d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 6, 2023
@sobolevn
sobolevn marked this pull request as ready for review April 6, 2023 17:50
@sobolevn sobolevn changed the title gh-103053: Skip the whole test_freeze module in tests on buildbots gh-103053: Skip the whole test_freeze module in tests on s390x with PGO Apr 6, 2023
@sobolevn

sobolevn commented Apr 7, 2023

Copy link
Copy Markdown
Member Author

@zware can you please take a look when you have the time?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
sobolevn requested a review from zware April 7, 2023 05:11
vstinner
vstinner requested changes Apr 7, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do that. It's ok to have a red buildbot, it doesn't prevent to release Python: it's only part of PEP 11 Tier 3.

Failures on these platforms do not block a release.

If you skip the failing test, as the maintainer of this platform, I will no be able to notice it :-(

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Apr 7, 2023
@bedevere-bot

bedevere-bot commented Apr 7, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn

sobolevn commented Apr 7, 2023

Copy link
Copy Markdown
Member Author

So, other options are:

  1. Increase the test timeout for this platform (maybe only for pgo builds)
  2. Try optimizing freeze process (can be very complex and error prone)
  3. Create another form of testing 🤔

Any ideas are welcome!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn sobolevn mentioned this pull request Apr 7, 2023
bpo-46523: fix tests rerun when setUp[Class|Module] fails #30895
Merged
@ambv

ambv commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

We can try with a greatly increased timeout for this particular platform and see if that's indeed the problem.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented May 22, 2023

Copy link
Copy Markdown
Member

Any ideas are welcome!

Use a subdirectory in the build area, instead of os_helper.temp_dir(), and guard against it being copied into itself recursively?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented May 23, 2023

Copy link
Copy Markdown
Member

Create another form of testing thinking

Honestly, I'm not convinced by the value of this test. If freeze is badly broken, everybody will notice since Python itself is also frozen, no? Or did I misunderstood the purpose of the test, or what's frozen exactly? Don't all core devs already indirectly test frozen Python?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner mentioned this pull request Sep 20, 2023
gh-103053: Skip test_freeze_simple_script() on PGO build #109591
Merged
@vstinner

vstinner commented Sep 20, 2023

Copy link
Copy Markdown
Member

Please don't do that. It's ok to have a red buildbot, it doesn't prevent to release Python: it's only part of PEP 11 Tier 3.
If you skip the failing test, as the maintainer of this platform, I will no be able to notice it :-(

I wrote PR #109591 to not skip the test on s390x, but only if Python is built with PGO, which is differerent.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn sobolevn closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner requested changes
@zware zware Awaiting requested review from zware

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @bedevere-bot @ambv @encukou @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.