GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103171: Document and test behaviour change in 3.11 for runtime-checkable protocols decorated with `@final` by AlexWaygood · Pull Request #103173 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Apr 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Typing: undocumented behaviour change for protocols decorated with @final and @runtime_checkable in 3.11 #103171

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
pythongh-103171: Document behaviour change in 3.11 for runtime-checka…
777f477 
…ble protocols decorated with `@final`
@AlexWaygood AlexWaygood added topic-typing needs backport to 3.11 only security fixes labels Apr 1, 2023
@AlexWaygood
AlexWaygood requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners April 1, 2023 15:36
@bedevere-bot bedevere-bot added the awaiting core review label Apr 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 1, 2023
Typing: undocumented behaviour change for protocols decorated with @final and @runtime_checkable in 3.11 #103171
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Apr 1, 2023
@AlexWaygood
AlexWaygood removed the request for review from gvanrossum April 1, 2023 15:36
@AlexWaygood
AlexWaygood marked this pull request as draft April 1, 2023 15:55
@AlexWaygood
Add a test, too
7acdd60
@AlexWaygood AlexWaygood changed the title gh-103171: Document behaviour change in 3.11 for runtime-checkable protocols decorated with @final gh-103171: Document and test behaviour change in 3.11 for runtime-checkable protocols decorated with @final Apr 1, 2023
@AlexWaygood
AlexWaygood marked this pull request as ready for review April 1, 2023 16:00
@AlexWaygood AlexWaygood added tests Tests in the Lib/test dir DO-NOT-MERGE labels Apr 1, 2023
@AlexWaygood

AlexWaygood commented Apr 1, 2023

Copy link
Copy Markdown
Member Author

Marking as DO-NOT-MERGE until discussion on the issue has finished: #103171 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra requested changes Jun 7, 2023
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to instead change the behavior, see the issue.

(Also I want this to go out of my review requested list.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Jun 7, 2023
@bedevere-bot

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Jun 7, 2023

Copy link
Copy Markdown
Member Author

I'd like to instead change the behavior, see the issue.

In that case I'll close this PR for now, since the better approach will probably be to fix the behavior in a PR to the 3.11 branch, and then "forward-port" the tests from that PR to main/3.12. And I won't be able to change the target branch on this PR without pinging all core developers past, present and future
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood closed this Jun 7, 2023
@AlexWaygood
AlexWaygood deleted the document-runtimecheckable-final-change branch June 7, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra requested changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes DO-NOT-MERGE docs Documentation in the Doc dir needs backport to 3.11 only security fixes skip news tests Tests in the Lib/test dir topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.