GeezerVison

All commit authors signed the Contributor License Agreement.

@iritkatriel Could you please take a look, as this is a follow-up to #101674 you already reviewed?

Cc @gaogaotiantian

1-based does seem more reasonable. But if we are fixing this, how about the code in inspect.findsource()? It's also 0-based.

@iritkatriel Could you please take a look, as this is a follow-up to #101674 you already reviewed?

Cc @gaogaotiantian

The bug in pdb that you describe in the issue may be new, but you are changing behaviour of inspect in the PR. Question is whether this is a bug in inspect.

The doc of inspect says this function Return a list of source lines and starting line number for an object. In my opinion, starting line number should not be 0. How is "starting from 0" and "starting from 1" different? They all include line 1 and there's no line 0. The fundamental of 0-based is that [0] means something and that's not the case in line number.

I would think this as a bug, but it's true that this is a breaking behavior. If we kept it as it is in inspect, I'd like to fix it in pdb.

If there's a fix in pdb that you can do so we don't release a new bug there, then let's do it. Changing inspect probably would require more discussion.

FYI @Yhg1s .

@iritkatriel Thank you for the quick response. That sounds reasonable. I can create a separate issue regarding inspect and then relink this PR, leaving #103225 unassigned for now. Is that OK?

@gaogaotiantian Thanks for pointing inspect.findsource() out. I will investigate it further and provide a summary in the new issue.

@iritkatriel @gaogaotiantian I have opened a new issue regarding inspect #103319

A solution may be to change the documentation, rather than the result, so that existing code does not break.

This PR is stale because it has been open for 30 days with no activity.