GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102799: use sys.exception() instead of sys.exc_info() in contextlib by iritkatriel · Pull Request #103311 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Apr 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This will be further simplified when PEP-707 or something like that is implemented, but for now I think this clarifies where we still need the triplet.

  • Issue: some usages of sys.exc_info can be replaced by more modern code #102799

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arhadthedev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@iritkatriel
pythongh-102799: use sys.exception() instead of sys.exc_info() in con…
ede88da 
…textlib
@iritkatriel
iritkatriel requested a review from 1st1 as a code owner April 6, 2023 11:58
@bedevere-bot bedevere-bot mentioned this pull request Apr 6, 2023
some usages of sys.exc_info can be replaced by more modern code #102799
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 6, 2023
@iritkatriel
fix Lib/test/test_contextlib_async.py
7adb1c4
@iritkatriel iritkatriel added the skip news label Apr 6, 2023
@iritkatriel
Merge branch 'main' into exc_info-contextlib
b212ce5
@iritkatriel
iritkatriel requested a review from ambv April 24, 2023 20:36
iritkatriel and others added 3 commits April 25, 2023 15:14
@iritkatriel
Merge branch 'main' into exc_info-contextlib
9aec505
@iritkatriel
Merge remote-tracking branch 'upstream/main' into exc_info-contextlib
50d77b0
@iritkatriel
Merge branch 'main' into exc_info-contextlib
05ea06d
@iritkatriel
iritkatriel requested a review from kumaraditya303 July 14, 2023 18:30
kumaraditya303
kumaraditya303 reviewed Jul 16, 2023
View reviewed changes
Comment thread Lib/contextlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel @kumaraditya303
exc_details[1] --> exc
cc74903 
Co-authored-by: Kumar Aditya <[email protected]>
kumaraditya303
kumaraditya303 approved these changes Jul 20, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 20, 2023
@kumaraditya303
kumaraditya303 merged commit eeff8e7 into python:main Jul 20, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 20, 2023
@iritkatriel
iritkatriel deleted the exc_info-contextlib branch July 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.