GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103088: Ensure POSIX venv scripts always use LF line endings by zooba · Pull Request #103591 · python/cpython

Conversation

@zooba

@zooba zooba commented Apr 17, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also touches the files in no meaningful way to ensure they get updated when pulling

  • Issue: If the working directory and the venv are on different disks, venv doesn't work in bash on Windows #103088

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
pythongh-103088: Ensure POSIX venv scrpits are always LF
41b49da 
Also touches the files in no meaningful way to ensure they get updated when pulling
@zooba zooba added the skip news label Apr 17, 2023
@zooba
zooba requested a review from vsajip as a code owner April 17, 2023 15:24
@bedevere-bot bedevere-bot mentioned this pull request Apr 17, 2023
If the working directory and the venv are on different disks, venv doesn't work in bash on Windows #103088
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 17, 2023
@zooba zooba changed the title gh-103088: Ensure POSIX venv scrpits are always LF gh-103088: Ensure POSIX venv scripts are always LF Apr 17, 2023
@zooba zooba changed the title gh-103088: Ensure POSIX venv scripts are always LF gh-103088: Ensure POSIX venv scripts always use LF line endings Apr 17, 2023
@zooba
zooba merged commit eb5fd31 into python:main Apr 17, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 17, 2023
@zooba
zooba deleted the gh-103088 branch April 17, 2023 16:34
@zooba zooba added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Apr 17, 2023
@bedevere-bot

bedevere-bot commented Apr 17, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit 41b49da 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Apr 17, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit 41b49da 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 17, 2023
@zooba
zooba restored the gh-103088 branch April 17, 2023 16:34
@zooba
zooba deleted the gh-103088 branch April 17, 2023 16:34
@zooba
zooba restored the gh-103088 branch April 17, 2023 16:35
@zooba
zooba deleted the gh-103088 branch April 17, 2023 17:02
@daytonb daytonb mentioned this pull request Apr 21, 2023
venv activate bash script has wrong line endings in Windows #76632
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@zooba @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.