GeezerVison is showing github.com — gh-103092: Isolate ctypes by aisk · Pull Request #103612 · python/cpython
Conversation
aisk
commented
Apr 18, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
- Using multi-phase initialization for
_ctypes module
- port
PyCStructType_Type to heap type
- port
UnionType_Type to heap type
- port
PyCPointerType_Type to heap type
- port
PyCArrayType_Type to heap type
- port
PyCSimpleType_Type to heap type
- port
PyCFuncPtrType_Type to heap type
- port
Struct_Type to heap type
- port
Union_Type to heap type
- port
PyCPointer_Type to heap type
- port
PyCArray_Type to heap type
- port
Simple_Type to heap type
- port
PyCFuncPtr_Type to heap type
- port
PyCField_Type to heap type
- port
DictRemover_Type to heap type
- port
StructParam_Type to heap type
- port
PyComError_Type to heap type
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
arhadthedev reacted with thumbs up emoji
|
@aisk, are you basing your current _ctypes work off of this draft PR? If not, perhaps we should close it.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I was trying to enable multi-phase initialization and per-interpreter state, as well as convert some types to heap types in this PR. However, I found that the API to find a module state by type PyType_GetModuleByDef requires the parent type (or children? I forgot) to be converted first.
This made it much harder to finish, so I copied some code from this PR to #113620. Therefore, this should be closed now.
|
erlend-aasland reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.