GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89415: Add source-specific multicast constants to socket module by rmehyde · Pull Request #103684 · python/cpython

Conversation

@rmehyde

@rmehyde rmehyde commented Apr 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Addresses #89415 by adding IP_UNBLOCK_SOURCE, IP_BLOCK_SOURCE, IP_ADD_SOURCE_MEMBERSHIP, and IP_DROP_SOURCE_MEMBERSHIP constants to the socket module if found in system headers.

I believe this follows the approach suggested by @gpshead but this is my first contribution so please let me know what I missed!

  • Issue: Missing support for Source Specific Multicast #89415

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
multiplemonomials reacted with hooray emoji
All reactions
  • 🎉 1 reaction
rmehyde added 2 commits April 22, 2023 10:52
@rmehyde
pythongh-89415: Add socket options for source-specific multicast
0633a2e
@rmehyde
add news blurb
174a2cb
@bedevere-bot bedevere-bot mentioned this pull request Apr 22, 2023
Missing support for Source Specific Multicast #89415
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 22, 2023
@ghost

ghost commented Apr 22, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rmehyde
Merge branch 'main' into socket-ssm_issue-89415
7bbf19c
@arhadthedev arhadthedev added the extension-modules C modules in the Modules dir label Apr 22, 2023
@rmehyde
restify news
49481a7
arhadthedev
arhadthedev reviewed Apr 25, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2023-04-22-11-20-27.gh-issue-89415.YHk760.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev
Fix the news entry
d1df7cb
gpshead
gpshead approved these changes Apr 27, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 27, 2023
@gpshead gpshead self-assigned this Apr 27, 2023
@gpshead
gpshead merged commit 1d99e9e into python:main Apr 27, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 27, 2023
@rmehyde
rmehyde deleted the socket-ssm_issue-89415 branch April 27, 2023 19:37
@sobolevn sobolevn mentioned this pull request Jun 3, 2023
gh-89415: Mention new IP_* constants in socket module in the docs #105266
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments
@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

extension-modules C modules in the Modules dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@rmehyde @gpshead @arhadthedev @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.