GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-91687: modernize dataclass example typing (GH-103773) by miss-islington · Pull Request #103774 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

modernize dataclass example typing list rather than List and comment as to that line being the alluded too error.
(cherry picked from commit 7ef614c)

Co-authored-by: Allan Lago [email protected]

  • Issue: Two (possible) improvements at dataclasses.rst #91687

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@alago1 @miss-islington
pythongh-91687: modernize dataclass example typing (pythonGH-103773)
f56f910
modernize dataclass example typing `list` rather than `List` and comment as to that line being the alluded too error.
(cherry picked from commit 7ef614c)

Co-authored-by: Allan Lago <[email protected]>
@miss-islington
miss-islington requested a review from ericvsmith as a code owner April 24, 2023 17:16
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Apr 24, 2023
This was referenced Apr 24, 2023
Two (possible) improvements at dataclasses.rst #91687
Closed
gh-91687: fix dataclass example typing #103773
Merged
@bedevere-bot bedevere-bot added the awaiting review label Apr 24, 2023
gpshead
gpshead approved these changes Apr 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 24, 2023
@ambv
ambv enabled auto-merge (squash) April 25, 2023 00:11
@ambv
ambv disabled auto-merge April 25, 2023 00:12
ambv added 2 commits April 25, 2023 02:13
@ambv
Merge branch '3.11' into backport-7ef614c-3.11
b52528e
@ambv
Merge branch '3.11' into backport-7ef614c-3.11
cd20610
@ambv
ambv merged commit 026c3e9 into python:3.11 Apr 25, 2023
@miss-islington
miss-islington deleted the backport-7ef614c-3.11 branch April 25, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gpshead @ambv @bedevere-bot @alago1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.