GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103826: fix unused variable warning introduced in gh-102343 by sunmy2019 · Pull Request #103825 · python/cpython

Conversation

@sunmy2019

@sunmy2019 sunmy2019 commented Apr 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

gh-102343 introduced a variable used only in the assert macro, causing unused variable warnings in release mode.

  • Issue: Fix unused variable warning #103826

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sunmy2019
fix unused variable warning
6f12eef
@sunmy2019
sunmy2019 requested a review from markshannon as a code owner April 25, 2023 03:54
@bedevere-bot bedevere-bot added the awaiting review label Apr 25, 2023
@sunmy2019

sunmy2019 commented Apr 25, 2023

Copy link
Copy Markdown
Member Author

@ericvsmith

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sunmy2019 sunmy2019 changed the title fix unused variable warning introduced in gh-102343 gh-103826: fix unused variable warning introduced in gh-102343 Apr 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 25, 2023
Fix unused variable warning #103826
Closed
@arhadthedev arhadthedev added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Apr 25, 2023
kumaraditya303
kumaraditya303 approved these changes Apr 25, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 25, 2023
@kumaraditya303 kumaraditya303 added the skip news label Apr 25, 2023
@kumaraditya303
kumaraditya303 merged commit 0acea96 into python:main Apr 25, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 25, 2023
@sunmy2019
sunmy2019 deleted the fix-warning branch May 10, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sunmy2019 @kumaraditya303 @arhadthedev @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.