GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103629: Update typing.Unpack docs in compliance with PEP 692 by franekmagiera · Pull Request #103894 · python/cpython

Conversation

@franekmagiera

@franekmagiera franekmagiera commented Apr 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Implement PEP 692 #103629

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franekmagiera
pythonGH-103629: Update typing.Unpack docs in compliance with PEP 692
9529f87
@franekmagiera
franekmagiera requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners April 26, 2023 21:33
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Apr 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 26, 2023
Implement PEP 692 #103629
Closed
@bedevere-bot bedevere-bot added the awaiting review label Apr 26, 2023
@JelleZijlstra

JelleZijlstra commented Apr 26, 2023

Copy link
Copy Markdown
Member

Thanks! Could you add an entry to the 3.12 What's New and to the NEWS as well?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franekmagiera

franekmagiera commented Apr 26, 2023

Copy link
Copy Markdown
Contributor Author

Thought about doing it in a separate PR but I can add it as a part of this one :) let me do that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added topic-typing 3.12 only security fixes labels Apr 26, 2023
@franekmagiera
pythonGH-103629: Update NEWS and whatsnew with PEP-692 information
2cfa405
AlexWaygood
AlexWaygood approved these changes Apr 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 26, 2023
JelleZijlstra
JelleZijlstra approved these changes Apr 26, 2023
View reviewed changes
@AlexWaygood
AlexWaygood merged commit dc3f975 into python:main Apr 26, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 26, 2023
@AlexWaygood

AlexWaygood commented Apr 26, 2023

Copy link
Copy Markdown
Member

Thanks @franekmagiera!
franekmagiera reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rinarakaki
rinarakaki reviewed Oct 3, 2023
View reviewed changes
Comment thread Doc/library/typing.rst

from typing import TypedDict, Unpack

class Movie(TypedDict):

@rinarakaki rinarakaki Oct 3, 2023

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 space tab would've been more consistent.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra Oct 3, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 spaces are the convention in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
+1 more reviewer
@rinarakaki rinarakaki rinarakaki left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12 only security fixes docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@franekmagiera @JelleZijlstra @AlexWaygood @rinarakaki @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.