GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103092: Adapt _ctypes's PyCStgDict type to heap type by erlend-aasland · Pull Request #103932 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 27, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Port PyCStgDict_Type to heap type.

  • Issue: Isolate Stdlib Extension Modules #103092

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
erlend-aasland requested a review from kumaraditya303 April 27, 2023 16:31
@bedevere-bot bedevere-bot mentioned this pull request Apr 27, 2023
Isolate Stdlib Extension Modules #103092
Closed
24 of 25 tasks
@bedevere-bot bedevere-bot added the awaiting core review label Apr 27, 2023
@erlend-aasland erlend-aasland added the skip news label Apr 27, 2023
@erlend-aasland

erlend-aasland commented Apr 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

This probably fails because of the dict hacks in StructUnionType_new (wild guess).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 self-requested a review April 27, 2023 23:31
erlend-aasland added 2 commits May 15, 2023 15:19
@erlend-aasland @kumaraditya303
pythongh-103092: Isolate _ctypes, part 2
4b4f8f9 
Port PyCStgDict_Type to heap type.
@erlend-aasland @kumaraditya303
sort
56fd7e9
@kumaraditya303
kumaraditya303 force-pushed the isolate-ctypes/part2-take2 branch from 11c91c9 to 56fd7e9 Compare May 15, 2023 09:49
@kumaraditya303

kumaraditya303 commented May 30, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

While I am still trying to figure out where it breaks, you may proceed to port other simpler types (if there are any).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jul 12, 2023

Copy link
Copy Markdown
Member

What's the status of this PR? Is it ready for review? It's still marked as a draft.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
neonene
neonene reviewed Jan 4, 2024
View reviewed changes
Comment thread Modules/_ctypes/stgdict.c
PyCStgDict_traverse(StgDictObject *self, visitproc visit, void *arg)
{
Py_VISIT(Py_TYPE(self));
Py_VISIT(self->proto);

@neonene neonene Jan 4, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an extra visit to the proto member? The CDataType_traverse function in _ctypes.c has an explicit Py_VISIT(dict->proto).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
Merge branch 'main' into isolate-ctypes/part2-take2
540c903
@erlend-aasland erlend-aasland changed the title gh-103092: Isolate _ctypes, part 2 gh-103092: Adapt _ctypes.PyCStgDict_Type to heap type Jan 9, 2024
@erlend-aasland erlend-aasland changed the title gh-103092: Adapt _ctypes.PyCStgDict_Type to heap type gh-103092: Adapt _ctypes's PyCStgDict type to heap type Jan 9, 2024
@erlend-aasland

erlend-aasland commented Jan 9, 2024

Copy link
Copy Markdown
Contributor Author

I don't have the bandwidth to follow up this right now; abandoning this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Jan 9, 2024
@erlend-aasland
erlend-aasland deleted the isolate-ctypes/part2-take2 branch January 9, 2024 21:47
@vstinner vstinner mentioned this pull request Jan 19, 2024
Convert _ctypes static types (and the "meta class") to heap types #114314
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303
@corona10 corona10 Awaiting requested review from corona10
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner
1 more reviewer
@neonene neonene neonene left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @kumaraditya303 @vstinner @neonene @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.