GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103978: avoid using 'class' as an identifier by carljm · Pull Request #103979 · python/cpython

Conversation

@carljm

@carljm carljm commented Apr 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

fixes #103978

  • Issue: 'class' parameter name in headers breaks building C++ extensions #103978

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carljm
pythongh-103978: avoid using 'class' as an identifier
6a08ed6
@bedevere-bot bedevere-bot mentioned this pull request Apr 28, 2023
'class' parameter name in headers breaks building C++ extensions #103978
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 28, 2023
@carljm carljm added the skip news label Apr 28, 2023
@carljm carljm mentioned this pull request Apr 28, 2023
gh-87729: specialize LOAD_SUPER_ATTR_METHOD #103809
Merged
JelleZijlstra
JelleZijlstra approved these changes Apr 28, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 28, 2023
brandtbucher
brandtbucher approved these changes Apr 28, 2023
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, super minor... but maybe use cls instead of klass for this?

It's a much more common name in our codebase... and I personally like it a lot more. 🙃

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm, JelleZijlstra, and Fidget-Spinner reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@carljm
prefer cls over klass
8d652a3
@carljm
carljm enabled auto-merge (squash) April 28, 2023 18:51
@carljm
carljm merged commit ebf97c5 into python:main Apr 28, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 28, 2023
@carljm
carljm deleted the fixclass branch April 28, 2023 19:21
@tacaswell

tacaswell commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@brandtbucher brandtbucher brandtbucher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'class' parameter name in headers breaks building C++ extensions

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@carljm @tacaswell @JelleZijlstra @brandtbucher @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.