GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-104114: Fix `pathlib.WindowsPath.glob()` use of literal pattern segment case by barneygale · Pull Request #104116 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented May 3, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

We now use _WildcardSelector to evaluate literal pattern segments, which allows us to retrieve the real filesystem case.

This change is necessary in order to implement a case_sensitive argument (see #81079) and a follow_symlinks argument (see #77609).

  • Issue: pathlib.WindowsPath.glob() preserves case of literal pattern segments #104114

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-104114: Fix pathlib.WindowsPath.glob() use of literal patt…
1f58b94 
…ern segment case

We now use `_WildcardSelector` to evaluate literal pattern segments, which
allows us to retrieve the real filesystem case.

This change is necessary in order to implement a *case_sensitive* argument
(see pythonGH-81079) and a *follow_symlinks* argument (see pythonGH-77609).
@barneygale barneygale added the topic-pathlib label May 3, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 3, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 3, 2023
pathlib.WindowsPath.glob() preserves case of literal pattern segments #104114
Closed
@barneygale barneygale mentioned this pull request May 3, 2023
GH-81079: Add case_sensitive argument to pathlib.Path.glob() #102710
Merged
@barneygale
Merge branch 'main' into pythongh-104114-windowspath-literal-pattern-…
6fd03f4 
…case
zooba
zooba approved these changes May 3, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 3, 2023
@barneygale
barneygale merged commit da1980a into python:main May 3, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 3, 2023
@barneygale

barneygale commented May 3, 2023

Copy link
Copy Markdown
Contributor Author

Thanks Steve!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@barneygale @zooba @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.