GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-103247: bypass the import cache on the _require_loader helper by FFY00 · Pull Request #104186 · python/cpython

Conversation

@FFY00

@FFY00 FFY00 commented May 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is not a fix for the importlib test monkeypatching leakage but it's something that we probably should be doing anyway.

  • Issue: test_pickle/test_pickletools fail when running tests sequentially. #103247

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FFY00
pythonGH-103247: bypass the import cache on the _require_loader helper
8be54d3 
This is not a fix for the importlib test monkeypatching leakage but it's
something that we probably should be doing anyway.

Signed-off-by: Filipe Laíns <[email protected]>
@FFY00 FFY00 added the skip news label May 5, 2023
@FFY00
FFY00 requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners May 5, 2023 00:50
@bedevere-bot bedevere-bot mentioned this pull request May 5, 2023
test_pickle/test_pickletools fail when running tests sequentially. #103247
Closed
@bedevere-bot bedevere-bot added the awaiting core review label May 5, 2023
@FFY00

FFY00 commented May 5, 2023

Copy link
Copy Markdown
Member Author

cc @JelleZijlstra as the original reporter
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brettcannon
brettcannon approved these changes May 10, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 10, 2023
sunmy2019
sunmy2019 approved these changes May 10, 2023
View reviewed changes
@FFY00

FFY00 commented Aug 24, 2023

Copy link
Copy Markdown
Member Author

It seems this fell off mental work pool and I only noticed it now. Since we have approvals, I am gonna update the branch and schedule it for merging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FFY00
Merge branch 'main' into pythongh-103247-_require_loader
e18626c
@FFY00
FFY00 enabled auto-merge (squash) August 24, 2023 20:25
@FFY00
FFY00 merged commit feb9a49 into python:main Aug 24, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 24, 2023
@carljm carljm mentioned this pull request Aug 30, 2023
test_import leaks references #108696
Closed
2 tasks done
@carljm

carljm commented Aug 30, 2023

Copy link
Copy Markdown
Member

Bisection shows that the merge of this PR introduced a reference leak in test_import, so all refleak buildbots are red: #108696
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FFY00

FFY00 commented Aug 30, 2023

Copy link
Copy Markdown
Member Author

@carljm thanks for the catch, let's revert then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@carljm carljm mentioned this pull request Aug 30, 2023
gh-108696: revert bypassing import cache in test_import helper #108698
Merged
@carljm

carljm commented Aug 30, 2023

Copy link
Copy Markdown
Member

@carljm thanks for the catch, let's revert then.

#108698
sunmy2019 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@sunmy2019 sunmy2019 sunmy2019 approved these changes
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@FFY00 @carljm @brettcannon @sunmy2019 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.