GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] GH-89812: Add `tarfile.TarPath` by barneygale · Pull Request #104272 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented May 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Split pathlib.Path into _AbstractPath and Path
    • Make _AbstractPath.stat(), open() and iterdir() abstract
    • Implement _AbstractPath._scandir() via iterdir()
      • Add follow_symlinks argument to is_dir() for consistency with os.DirEntry.is_dir()
      • Use context manager enter value in walk() to enable use of a contextlib.nullcontext()
    • Implement _AbstractPath.is_mount() and is_junction() using stat(), restoring implementation from before gh-86943: implement pathlib.WindowsPath.is_mount() #31458 in the former case.
  • [more to come!]
  • Issue: Add tarfile.TarPath #89812

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
Add pathlib._AbstractPath
042cb6c
@barneygale barneygale added the topic-pathlib label May 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 7, 2023
Add tarfile.TarPath #89812
Open
@bedevere-bot bedevere-bot added the awaiting core review label May 7, 2023
@barneygale
Add tests for pathlib._AbstractPath
59cf62b
@barneygale

barneygale commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

Closing - will log a fresh PR soon :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@barneygale @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.