GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs (#104287) by erlend-aasland · Pull Request #104381 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 11, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The SQLite C API sqlite3_changes() can only be relied upon when the
current active statement has been run to completion.

  • Issue: SQLite rowcount is corrupted when combining UPDATE RETURNING w/ id IN (?) #101117

📚 Documentation preview 📚: https://cpython-previews--104381.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
[3.11] pythongh-101117: Improve accuracy of sqlite3.Cursor.rowcount d…
ad6faec 
…ocs (python#104287)

The SQLite C API sqlite3_changes() can only be relied upon when the
current active statement has been run to completion.
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner May 11, 2023 08:47
@erlend-aasland erlend-aasland added the skip news label May 11, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 11, 2023
This was referenced May 11, 2023
SQLite rowcount is corrupted when combining UPDATE RETURNING w/ id IN (?) #101117
Closed
gh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs #104287
Merged
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 11, 2023
@erlend-aasland
erlend-aasland merged commit 7055088 into python:3.11 May 11, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 11, 2023
@erlend-aasland
erlend-aasland deleted the 3.11-backport-sqlite-rowcount-docs branch May 11, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.