GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104404: fix crasher with nested comprehensions plus lambdas by carljm · Pull Request #104442 · python/cpython

Conversation

@carljm

@carljm carljm commented May 12, 2023

Copy link
Copy Markdown
Member

The fix for gh-104357 (#104368) is the cause of this crash. We can't promote a local to a cell before analyze_cells has run, or we'll fail to see that that local resolves a free var from a child scope. Instead we have to record the names that need promoting to cell in the scope due to being a cell in an inlined comprehension, and handle them within analyze_cells.

Fixes gh-104404.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carljm
pythongh-104404: fix crasher with nested comprehensions plus lambdas
93e7f88
@bedevere-bot bedevere-bot added the awaiting core review label May 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 12, 2023
PEP 709 segfault with nested comprehensions plus lambdas #104404
Closed
@carljm carljm added the skip news label May 12, 2023
@carljm
carljm requested a review from JelleZijlstra May 12, 2023 22:46
JelleZijlstra
JelleZijlstra approved these changes May 13, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 13, 2023
@JelleZijlstra
JelleZijlstra merged commit 563c7dc into python:main May 13, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 13, 2023
@carljm
carljm deleted the crasher branch June 16, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PEP 709 segfault with nested comprehensions plus lambdas

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@carljm @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.