GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104539: Fix indentation error in logging.config.rst by jnoordsij · Pull Request #104540 · python/cpython

Conversation

@jnoordsij

@jnoordsij jnoordsij commented May 16, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I think this should solve #104539, but I'm not entirely sure.

  • Issue: Indentation issue in logging.config documentation page #104539

📚 Documentation preview 📚: https://cpython-previews--104540.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jnoordsij
Fix indentation error in logging.config.rst
ba0566e
@jnoordsij
jnoordsij requested a review from vsajip as a code owner May 16, 2023 10:58
@ghost

ghost commented May 16, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label May 16, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 16, 2023
Indentation issue in logging.config documentation page #104539
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels May 16, 2023
@hugovk

hugovk commented May 16, 2023

Copy link
Copy Markdown
Member

Please could you make this PR against the main branch instead of 3.11? We can then backport it to 3.11 from there.

Don't change the base branch at the top of this PR, because it rarely works as planned and ends up pinging lots of people through the CODEOWNERS file. Instead, close this PR and re-open a new one.

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk removed the request for review from vsajip May 16, 2023 11:10
@vsajip

vsajip commented May 16, 2023

Copy link
Copy Markdown
Member

I'll close this, and wait for the patch against the main branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsajip vsajip closed this May 16, 2023
@jnoordsij

jnoordsij commented May 16, 2023

Copy link
Copy Markdown
Contributor Author

Please could you make this PR against the main branch instead of 3.11? We can then backport it to 3.11 from there.

Don't change the base branch at the top of this PR, because it rarely works as planned and ends up pinging lots of people through the CODEOWNERS file. Instead, close this PR and re-open a new one.

Thank you!

Ah that makes sense! Will open a new PR soon.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jnoordsij
jnoordsij deleted the patch-1 branch May 16, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jnoordsij @hugovk @vsajip @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.