GeezerVison is showing github.com — [3.11] gh-87474: Fix file descriptor leaks in subprocess.Popen (GH-96351) by miss-islington · Pull Request #104563 · python/cpython
Conversation
miss-islington
commented
May 16, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
This fixes several ways file descriptors could be leaked from subprocess.Popen constructor during error conditions by opening them later and using a context manager "fds to close" registration scheme to ensure they get closed before returning.
(cherry picked from commit 3a4c44b)
Co-authored-by: cptpcrd [email protected]
Co-authored-by: Gregory P. Smith [Google] [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…GH-96351)
This fixes several ways file descriptors could be leaked from `subprocess.Popen` constructor during error conditions by opening them later and using a context manager "fds to close" registration scheme to ensure they get closed before returning.
---------
(cherry picked from commit 3a4c44b)
Co-authored-by: cptpcrd <[email protected]>
Co-authored-by: Gregory P. Smith [Google] <[email protected]>
This was referenced May 16, 2023
Reviewers
gpshead
Awaiting requested review from gpshead
gpshead is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.