GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] typing: Add more tests for TypeVar (GH-104571) by JelleZijlstra · Pull Request #104577 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 17, 2023

Copy link
Copy Markdown
Member

During the PEP 695 implementation at one point I made TypeVar.name return garbage, and all of test_typing passed. So I decided to add a few more tests. (cherry picked from commit 2693194)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
[3.11] typing: Add more tests for TypeVar (pythonGH-104571)
856e8fd 
During the PEP 695 implementation at one point I made
TypeVar.__name__ return garbage, and all of test_typing passed.
So I decided to add a few more tests. In the process I discovered
a minor incompatibility from the C implementation of TypeVar:
empty constraints were returned as None instead of an empty tuple..
(cherry picked from commit 2693194)

Co-authored-by: Jelle Zijlstra <[email protected]>
@JelleZijlstra
JelleZijlstra requested review from AlexWaygood, Fidget-Spinner and gvanrossum as code owners May 17, 2023 13:12
@bedevere-bot bedevere-bot added the awaiting core review label May 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 17, 2023
typing: Add more tests for TypeVar #104571
Merged
@bedevere-bot bedevere-bot added skip issue skip news tests Tests in the Lib/test dir labels May 17, 2023
JelleZijlstra
JelleZijlstra commented May 17, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
remove inapplicable test
a1496e1
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) May 17, 2023 13:38
@JelleZijlstra
JelleZijlstra merged commit f106aef into python:3.11 May 17, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 17, 2023
@JelleZijlstra
JelleZijlstra deleted the backport-2693194-3.11 branch May 17, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.