GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104600: Make function.__type_params__ writable by JelleZijlstra · Pull Request #104601 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 18, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

And set it in functools.update_wrapper.

  • Issue: function.__type_params__ and type.__type_params__ should be writable #104600

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-104600: Make function.__type_params__ writable
7c04199
@JelleZijlstra
JelleZijlstra requested a review from rhettinger as a code owner May 18, 2023 03:57
@bedevere-bot bedevere-bot added the awaiting core review label May 18, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 18, 2023
function.__type_params__ and type.__type_params__ should be writable #104600
Closed
@JelleZijlstra
blurb
8103023
@rhettinger
rhettinger removed their request for review May 18, 2023 04:05
@JelleZijlstra
fix test
4be56e1
carljm
carljm approved these changes May 18, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 18, 2023
Eclips4
Eclips4 reviewed May 18, 2023
View reviewed changes
Comment thread Objects/funcobject.c
{
/* Not legal to del f.__type_params__ or to set it to anything
* other than a tuple object. */
if (value == NULL || !PyTuple_Check(value)) {

@Eclips4 Eclips4 May 18, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to use PyTuple_CheckExact instead of PyTuple_Check? With PyTuple_Check we can pass to __type_params__ subclass of tuple. May it break something?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra May 18, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really use the __type_params__ in the interpreter, so there's low risk. The other attributes also allow subclasses (e.g. check func_set_defaults and func_set_name).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4 and carljm reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@JelleZijlstra
JelleZijlstra merged commit 3fadd7d into python:main May 18, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 18, 2023
@JelleZijlstra
JelleZijlstra deleted the settypeparams branch May 18, 2023 23:45
@AlexWaygood AlexWaygood mentioned this pull request Sep 9, 2023
functools.update_wrapper and functools.wraps cannot be used in mypycified files on py312 python/mypy#16077
Closed
@JelleZijlstra
JelleZijlstra restored the settypeparams branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments
@carljm carljm carljm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @carljm @Eclips4 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.