GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104050: Add more type annotations to Argument Clinic by erlend-aasland · Pull Request #104631 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 18, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Annotate methods of the following classes:

  • class Function
  • class Parameter
  • class LandMine
  • Issue: Add type annotations to clinic.py #104050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-104050: Add more type annotations to Argument Clinic
36ae292 
Annotate methods of the following classes:

- class Function
- class Parameter
- class LandMine
@erlend-aasland erlend-aasland added the skip news label May 18, 2023
@erlend-aasland
erlend-aasland requested a review from AlexWaygood May 18, 2023 22:49
@bedevere-bot bedevere-bot added the awaiting core review label May 18, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 18, 2023
Add type annotations to clinic.py #104050
Closed
@erlend-aasland
erlend-aasland marked this pull request as draft May 18, 2023 22:54
@bedevere-bot bedevere-bot removed the awaiting core review label May 18, 2023
@erlend-aasland

erlend-aasland commented May 18, 2023

Copy link
Copy Markdown
Contributor Author

(I'll fix the errors tomorrow)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 20, 2023

Copy link
Copy Markdown
Contributor Author

(Waiting for #104648)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 7 commits May 20, 2023 23:56
@erlend-aasland
Pull in main
4a6fdfe
@erlend-aasland
Pull in main
d4055ea
@erlend-aasland
Fix return converter
1da5282
@erlend-aasland
WIP
ccd1bb6
@erlend-aasland
str does the trick?
3877c7b
@erlend-aasland
str does the trick again?
e239ab5
@erlend-aasland
Partially revert Function.copy() annotation
0ecd3a1
@erlend-aasland
erlend-aasland marked this pull request as ready for review May 21, 2023 20:56
@bedevere-bot bedevere-bot added the awaiting core review label May 21, 2023
erlend-aasland
erlend-aasland commented May 21, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes May 21, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 21, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 21, 2023 21:20
@erlend-aasland
erlend-aasland merged commit 6ba8406 into python:main May 21, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 21, 2023
@erlend-aasland
erlend-aasland deleted the typed-clinic/more-classes branch May 21, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.