GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-104615: don't make unsafe swaps in apply_static_swaps (GH-104620). by carljm · Pull Request #104636 · python/cpython

Conversation

@carljm

@carljm carljm commented May 19, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 0589c6a)

  • Issue: compiler can incorrectly optimize a run of stores to the same name preceded by a SWAP #104615

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carljm
[3.11] pythongh-104615: don't make unsafe swaps in apply_static_swaps (…
eb83a26 
…pythonGH-104620).

(cherry picked from commit 0589c6a)

Co-authored-by: Carl Meyer <[email protected]>
This was referenced May 19, 2023
compiler can incorrectly optimize a run of stores to the same name preceded by a SWAP #104615
Closed
gh-104615: don't make unsafe swaps in apply_static_swaps #104620
Merged
@carljm
carljm marked this pull request as ready for review May 19, 2023 00:55
@carljm
carljm requested a review from markshannon as a code owner May 19, 2023 00:55
@bedevere-bot bedevere-bot added the awaiting core review label May 19, 2023
@carljm
carljm requested review from brandtbucher and iritkatriel May 19, 2023 00:55
@carljm

carljm commented May 19, 2023

Copy link
Copy Markdown
Member Author

This required manual backport, but mostly just to eliminate all the stuff from the 3.12 PR that had to do with directly testing the optimizer, since the APIs for that don't exist in 3.11. Also there's no STORE_FAST_MAYBE_NULL. Still a pretty straightforward backport, but since it was manual I'll wait for review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher
brandtbucher approved these changes May 19, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 19, 2023
@carljm
carljm merged commit 667e4ec into python:3.11 May 19, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 19, 2023
@carljm
carljm deleted the backport-0589c6a-3.11 branch May 19, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@carljm @brandtbucher @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.