GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104469: Convert _testcapi/long to use AC by corona10 · Pull Request #104720 · python/cpython

Conversation

@corona10

@corona10 corona10 commented May 21, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Improve the readability and maintainability of test_capi using the AC #104469

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label May 21, 2023
@corona10
corona10 requested a review from erlend-aasland May 21, 2023 12:09
@bedevere-bot bedevere-bot mentioned this pull request May 21, 2023
Improve the readability and maintainability of test_capi using the AC #104469
Closed
@corona10
corona10 requested a review from sobolevn May 21, 2023 12:09
@corona10 corona10 added the skip news label May 21, 2023
@corona10
pythongh-104469: Convert _testcapi/long to use AC
6bc3973
@corona10
corona10 force-pushed the gh-104469-long branch 2 times, most recently from 3c78173 to 71a0b12 Compare May 21, 2023 14:45
@corona10
Update
5c417a6
@corona10
corona10 force-pushed the gh-104469-long branch from 71a0b12 to 5c417a6 Compare May 21, 2023 14:48
sobolevn
sobolevn reviewed May 22, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_testcapi/long.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapi/long.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapi/long.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 2 commits May 22, 2023 18:04
@corona10
Address code review
081e139
@corona10
update
48c366b
@corona10
corona10 requested a review from sobolevn May 23, 2023 11:43
sobolevn
sobolevn approved these changes May 23, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 merged commit 76170f5 into python:main May 23, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 23, 2023
@corona10
corona10 deleted the gh-104469-long branch May 23, 2023 13:52
@corona10 corona10 mentioned this pull request Jul 9, 2023
gh-104469 Convert_testcapi/vectorcall.c to use AC #106557
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@corona10 @sobolevn @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.