GeezerVison is showing github.com — gh-100238: Vendor distutils for peg_generator by lysnikolaou · Pull Request #104744 · python/cpython
Conversation
lysnikolaou
commented
May 22, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
This puts all of distutils (except for the tests) under Tools and uses that both in the c-analyzer and the peg-generator. Stripping all the unnecessary parts of distutils should be done after b1 is released.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
lysnikolaou
changed the title
gh-92584: Vendor distutils for peg_generator
gh-100238: Vendor distutils for peg_generator
May 22, 2023
|
Is there a reason we can't use setuptools via pip install rather than bringing back all this code we just removed?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Not really. I opened this in a hurry to give @Yhg1s the option to unskip test_peg_generator before beta1, since the associated issue was marked as a release blocker. Since the consensus is that it's not, I'll take the time to port this to setuptools instead.
|
ned-deily reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
FFY00
Awaiting requested review from FFY00
FFY00 is a code owner
pablogsal
Awaiting requested review from pablogsal
pablogsal is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.