GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104764: Skip failing tests in test_enum that started failing. by Yhg1s · Pull Request #104765 · python/cpython

Conversation

@Yhg1s

@Yhg1s Yhg1s commented May 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Skip failing tests in test_enum that started failing when the version was bumped to 3.13.

  • Issue: test_enum tests fail because of the version bump to 3.13.0a0 #104764

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Yhg1s
Skip failing tests in test_enum that started failing when the version…
8f6936c 
… was

bumped to 3.13.
@Yhg1s Yhg1s added the skip news label May 22, 2023
@Yhg1s
Yhg1s requested a review from ethanfurman as a code owner May 22, 2023 22:54
@bedevere-bot bedevere-bot added the awaiting core review label May 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 22, 2023
test_enum tests fail because of the version bump to 3.13.0a0 #104764
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 22, 2023
@Eclips4

Eclips4 commented May 22, 2023

Copy link
Copy Markdown
Member

Nit: maybe use a @unittest.expectedFailure instead of bump version?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s

Yhg1s commented May 22, 2023

Copy link
Copy Markdown
Member Author

Nit: maybe use a @unittest.expectedFailure instead of bump version?

I don't know if they are expected, or why it wasn't using unittest.unexpectedFailure before, or what version they should be checking. I just want to get CI green after the version bump.
Eclips4 and gpshead reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes May 22, 2023
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this now to get CI green, we can adjust these tests later.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 22, 2023
vstinner
vstinner approved these changes May 22, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But the enum maintainer may consider to change the default behavior or the tests to make it better.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vstinner vstinner mentioned this pull request May 22, 2023
gh-102304: Fix Py_INCREF() stable ABI in debug mode #104763
Merged
@Yhg1s
Yhg1s merged commit 586aca3 into python:main May 22, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 22, 2023
@Yhg1s
Yhg1s deleted the disable-failing-enum-tests branch November 22, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Yhg1s @Eclips4 @vstinner @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.