GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-104773: PEP 594: Remove the imghdr module by vstinner · Pull Request #104777 · python/cpython Conversation
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
The Docs CI job fails with: Oh. It seems like the Sphinx EPUB builder requires the removed |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sphinx used to depend on imghdr, but no longer does as of Sphinx 6.2.0:
Therefore we'll need to start using Sphinx 6.2.0 for Python 3.13. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
@doko42 would it be managable from a Debian packaging point of view? Do we have some contacts with other distribs? I remember the last bump of |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@encukou Is requiring Sphinx 6.2.0 for Python 3.13 okay for Red Hat? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Avoid new Sphinx warnings:
diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst index 7a479c6e56..9b33155c5a 100644 --- a/Doc/whatsnew/3.11.rst +++ b/Doc/whatsnew/3.11.rst @@ -1735,7 +1735,7 @@ Modules +---------------------+---------------------+---------------------+---------------------+---------------------+ | :mod:`audioop` | :mod:`crypt` | :mod:`nis` | :mod:`sndhdr` | :mod:`uu` | +---------------------+---------------------+---------------------+---------------------+---------------------+ - | :mod:`cgi` | :mod:`imghdr` | :mod:`nntplib` | :mod:`spwd` | :mod:`xdrlib` | + | :mod:`cgi` | :mod:`!imghdr` | :mod:`nntplib` | :mod:`spwd` | :mod:`xdrlib` | +---------------------+---------------------+---------------------+---------------------+---------------------+ | :mod:`cgitb` | :mod:`mailcap` | :mod:`ossaudiodev` | :mod:`sunau` | | +---------------------+---------------------+---------------------+---------------------+---------------------+ diff --git a/Doc/whatsnew/3.5.rst b/Doc/whatsnew/3.5.rst index 14b6425cea..d13036f6fd 100644 --- a/Doc/whatsnew/3.5.rst +++ b/Doc/whatsnew/3.5.rst @@ -1252,7 +1252,7 @@ Oberkirch in :issue:`21800`.) imghdr ------ -The :func:`~imghdr.what` function now recognizes the +The :func:`!imghdr.what` function now recognizes the `OpenEXR <https://www.openexr.com>`_ format (contributed by Martin Vignali and Claudiu Popa in :issue:`20295`), and the `WebP <https://en.wikipedia.org/wiki/WebP>`_ format
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| * :mod:`chunk` | ||
| * :mod:`crypt` | ||
| * :mod:`imghdr` | ||
| * ``imghdr`` |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
| * ``imghdr`` | |
| * :mod:`!imghdr` |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| `filetype <https://pypi.org/project/filetype/>`_, | ||
| `puremagic <https://pypi.org/project/puremagic/>`_, | ||
| or `python-magic <https://pypi.org/project/python-magic/>`_ instead. | ||
| (Contributed by Victor Stinner in :gh:`104773`.) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Reference the PEP.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| Remove the ``imghdr`` module, deprecated in Python 3.11: use the projects | ||
| `filetype <https://pypi.org/project/filetype/>`_, `puremagic | ||
| <https://pypi.org/project/puremagic/>`_, or `python-magic | ||
| <https://pypi.org/project/python-magic/>`_ instead. Patch by Victor Stinner. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Reference the PEP.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Yes. It's OK for Fedora. (And RHEL will follow Fedora after some time.) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
We should likely prefer A |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| Removed | ||
| ======= | ||
|
|
||
| * Remove the ``imghdr`` module, deprecated in Python 3.11: use the projects |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
| * Remove the ``imghdr`` module, deprecated in Python 3.11: use the projects | |
| * Remove the :mod:`!imghdr` module, deprecated in Python 3.11: use the projects |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| @@ -0,0 +1,4 @@ | |||
| Remove the ``imghdr`` module, deprecated in Python 3.11: use the projects | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
| Remove the ``imghdr`` module, deprecated in Python 3.11: use the projects | |
| Remove the :mod:`!imghdr` module, deprecated in Python 3.11: use the projects |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
OpenSUSE is using Sphinx 7 for Python 3.12 builds Debian and Ubuntu are the only remaining distributions from the list we checked last time. A |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I created issue #104818 "Require Sphinx 6.2 to build Python 3.13 documentation". I propose to discuss updating Sphinx (or not) there. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I rebased the PR on the main branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
* Remove the Lib/test/imghdrdata/ directory. * Copy 5 pictures (gif, png, ppm, pgm, xbm) from removed Lib/test/imghdrdata/ to a new Lib/test/tkinterdata/ directory.
* Update Sphinx from 4.5 to 6.2 in Doc/requirements.txt.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we can use Sphinx 6.2 for the "normal" docs build and for doctest (both use requirements.txt), and still support 3.2 in Doc/requirements-oldest-sphinx.txt.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Right. I only upgraded Sphinx in the GHA "Doctest" job. It seems like increasing the minimum Sphinx version to build the documentation is not strictly required to remove the imghdr module. I prefer to decorelate the imghdr removal and increase the minimum Sphinx version to build the Python documentation. So far, still supporting Sphinx 3.2 makes it possible to build Python 3.13 documentation on Debian Stable: #104818 (comment) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.