GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104804: Remove webbrowser.MacOSX class, deprecated in Python 3.11 by hugovk · Pull Request #104816 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented May 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes #104804.

Remove webbrowser.MacOSX class, deprecated in Python 3.11 in gh-86421.

Also fix Sphinx warnings in webbrowser.rst (helps gh-101100):

  • I don't think we need to define envvars for PATH or KDEDIR

  • We could define .. envvar:: BROWSER right before the first mention, but it looks a little out of place having a BROWSER before the third paragraph. Thoughts?

  • I also don't think we need to define the dozen or so Mozilla, Opera etc. classes. They're listed in the table that shows which type name corresponds to each class, and some of them have extra details like how they're instantiated (Mozilla('mozilla'), GenericBrowser('lynx')), so plain literal text makes sense here. Repeating each class below would be a lot of duplication for little benefit, especially for this rather short page.

  • https://cpython-previews--104816.org.readthedocs.build/en/104816/library/webbrowser.html

📚 Documentation preview 📚: https://cpython-previews--104816.org.readthedocs.build/

  • Issue: Remove deprecated webbrowser.MacOSX class #104804

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
hugovk added 2 commits May 23, 2023 23:19
@hugovk
Remove webbrowser.MacOSX class, deprecated in Python 3.11
9d6603f
@hugovk
Fix Sphinx warnings
58edef7
@bedevere-bot bedevere-bot added the awaiting core review label May 23, 2023
@hugovk hugovk changed the title Remove webbrowser.MacOSX class, deprecated in Python 3.11 gh-104804: Remove webbrowser.MacOSX class, deprecated in Python 3.11 May 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 23, 2023
Remove deprecated webbrowser.MacOSX class #104804
Closed
@hugovk hugovk mentioned this pull request May 23, 2023
webbrowser.MacOSX is unused, untested and undocumented #86421
Closed
@serhiy-storchaka

serhiy-storchaka commented May 23, 2023

Copy link
Copy Markdown
Member

Would not be better to split this PR on two? One for removing, and other for tidying?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CAM-Gerlach CAM-Gerlach added the stdlib Standard Library Python modules in the Lib/ directory label May 23, 2023
@hugovk

hugovk commented May 23, 2023

Copy link
Copy Markdown
Member Author

I can do, but they are intertwined: this bit is removed, which otherwise has warnings that would need fixing, or waiting for part 1 to be merged:

.. deprecated-removed:: 3.11 3.13
   :class:`MacOSX` is deprecated, use :class:`MacOSXOSAScript` instead.

Seems easier to do both at once. But either way is fine for me :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach
CAM-Gerlach reviewed May 23, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a handful of doc-related suggestions. Otherwise, the core change looks good. The removal of the :class: syntax for things that are really code snippits (and not formally documented anyway) makes sense, as does silencing warnings for env vars not explicitly defined by or primarily/exclusively used by Python itself.

Ideally it would be nice to split it into two PRs as @serhiy-storchaka , but as a practical matter given they interlinked, maybe not worth the extra effort.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Library/2023-05-23-21-25-54.gh-issue-104804.78fiE6.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/3.11.0a1.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/webbrowser.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
hugovk and others added 5 commits May 24, 2023 00:03
@hugovk @CAM-Gerlach
Update docs
863db43 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@hugovk
Add MacOSXOSAScript as 'versionadded:: 3.2'
8325375
@hugovk
Merge remote-tracking branch 'upstream/main' into rm-webbrowser-MacOSX
3b676e5
@hugovk
Fix typo
ffb2e44
@hugovk
Merge branch 'main' into rm-webbrowser-MacOSX
38092f5
@hugovk hugovk added the 3.13 only security fixes label May 25, 2023
@hugovk hugovk mentioned this pull request May 25, 2023
gh-104773: PEP 594: Remove the audioop module #104937
Merged
vstinner
vstinner reviewed May 25, 2023
View reviewed changes
Comment thread Doc/library/webbrowser.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2023-05-23-21-25-54.gh-issue-104804.78fiE6.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes May 25, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you fix the typo in the NEWS entry.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 25, 2023
@hugovk @vstinner
Fix typo
4333217 
Co-authored-by: Victor Stinner <[email protected]>
@hugovk
hugovk merged commit 5ab4bc0 into python:main May 26, 2023
@hugovk
hugovk deleted the rm-webbrowser-MacOSX branch May 26, 2023 13:54
@bedevere-bot bedevere-bot removed the awaiting merge label May 26, 2023
@hugovk hugovk mentioned this pull request Apr 21, 2026
gh-137586: Replace 'osascript' with 'open' on macOS in webbrowser #146439
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments
@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.13 only security fixes stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated webbrowser.MacOSX class

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@hugovk @serhiy-storchaka @vstinner @CAM-Gerlach @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.