GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104837: Revert "gh-104341: Add a Separate "Running" Lock for Each Thread (gh-104754) by gpshead · Pull Request #104838 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented May 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 097b783 from PR #104754.

It broke CI and was not a minor change.

  • Issue: CI blocked: threading causing random tests to alter the execution environment and fail #104837

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
pythongh-104837: Revert "pythongh-104341: Add a Separate "Running" Lo…
5ceae3c 
…ck for Each Thread (pythongh-104754)"

This reverts commit 097b783.
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
CI blocked: threading causing random tests to alter the execution environment and fail #104837
Closed
@gpshead gpshead added the skip news label May 24, 2023
@gpshead
gpshead marked this pull request as ready for review May 24, 2023 08:00
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2023
@gpshead
gpshead merged commit 4b56e56 into python:main May 24, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 24, 2023
@gpshead
gpshead deleted the revert-pr-104754 branch May 24, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gpshead @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.