GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104876: Remove deprecated turtle.RawTurtle.settiltangle by hugovk · Pull Request #104877 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented May 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes #104876.

Remove the turtle.RawTurtle.settiltangle method, deprecated in docs since Python 3.1 and with a warning since Python 3.11.

📚 Documentation preview 📚: https://cpython-previews--104877.org.readthedocs.build/

  • Issue: Remove deprecated turtle.RawTurtle.settiltangle method #104876

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Remove deprecated turtle.RawTurtle.settiltangle
cb8a923
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2023
@hugovk hugovk added 3.13 only security fixes and removed awaiting core review labels May 24, 2023
@hugovk hugovk changed the title Remove deprecated turtle.RawTurtle.settiltangle gh-104876: Remove deprecated turtle.RawTurtle.settiltangle May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Remove deprecated turtle.RawTurtle.settiltangle method #104876
Closed
@hugovk
Merge branch 'main' into rm-turtle-settiltangle
6b8848e
@hugovk hugovk added the stdlib Standard Library Python modules in the Lib/ directory label May 25, 2023
@hugovk hugovk mentioned this pull request May 25, 2023
gh-104773: PEP 594: Remove the audioop module #104937
Merged
vstinner
vstinner approved these changes May 25, 2023
View reviewed changes

@vstinner vstinner left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I left minor remarks. Also, I never used the turtle module, so I don't know how to test this change. Lib/test/test_turtle.py checks that there is no regression, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/turtle.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting merge label May 25, 2023
hugovk and others added 3 commits May 25, 2023 19:16
@hugovk @vstinner
Improve wording
dd17c3e 
Co-authored-by: Victor Stinner <[email protected]>
@hugovk
Remove outdated comment
df25c04
@hugovk
Improve wording
e0fdf63
vstinner
vstinner approved these changes May 25, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
hugovk merged commit 10c4583 into python:main May 26, 2023
@hugovk
hugovk deleted the rm-turtle-settiltangle branch May 26, 2023 04:25
@bedevere-bot bedevere-bot removed the awaiting merge label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.13 only security fixes stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated turtle.RawTurtle.settiltangle method

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.