GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104873: Add typing.get_protocol_members and typing.is_protocol by JelleZijlstra · Pull Request #104878 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 24, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add typing.get_protocol_members and typing.is_protocol #104873

📚 Documentation preview 📚: https://cpython-previews--104878.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-104873: Add typing.get_protocol_members
25eacef
@JelleZijlstra
JelleZijlstra requested review from AlexWaygood, Fidget-Spinner and gvanrossum as code owners May 24, 2023 16:56
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Add typing.get_protocol_members and typing.is_protocol #104873
Closed
AlexWaygood
AlexWaygood requested changes May 24, 2023
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels May 24, 2023
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added 3 commits May 24, 2023 10:31
@JelleZijlstra
freeze the set
d8d5e1f
@JelleZijlstra
A few more
a44c0c5
@JelleZijlstra
Add is_protocol
47a723e
@JelleZijlstra JelleZijlstra changed the title gh-104873: Add typing.get_protocol_members gh-104873: Add typing.get_protocol_members and typing.is_protocol May 24, 2023
@JelleZijlstra

JelleZijlstra commented May 24, 2023

Copy link
Copy Markdown
Member Author

I didn't expect the Spanish inquisition!
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels May 24, 2023
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

Nobody expects the Spanish Inquisition!

@AlexWaygood: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from AlexWaygood May 24, 2023 18:04
AlexWaygood
AlexWaygood reviewed May 24, 2023
View reviewed changes
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra and others added 2 commits May 24, 2023 13:10
@JelleZijlstra @AlexWaygood
Apply suggestions from code review
d1e9dec 
Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra
Merge branch 'main' into protoattrs
4f3e627
AlexWaygood
AlexWaygood reviewed Jun 5, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra @AlexWaygood
Update Doc/whatsnew/3.13.rst
c91acbb 
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood reviewed Jun 5, 2023
View reviewed changes
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Make get_protocol_members(Protocol) raise; review responses
63aa543
AlexWaygood
AlexWaygood reviewed Jun 5, 2023
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
remove from None
06d0ed4
AlexWaygood
AlexWaygood approved these changes Jun 5, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd love to get a third opinion from @gvanrossum or @Fidget-Spinner on the API, if possible

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting change review label Jun 5, 2023
@bedevere-bot bedevere-bot added the awaiting merge label Jun 5, 2023
@JelleZijlstra

JelleZijlstra commented Jun 5, 2023

Copy link
Copy Markdown
Member Author

FYI I also just emailed typing-sig about this to ask for feedback.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added 2 commits June 12, 2023 21:23
@JelleZijlstra
Merge branch 'main' into protoattrs
4caf12c
@JelleZijlstra
bad merge
f9efdc7
@JelleZijlstra

JelleZijlstra commented Jun 13, 2023

Copy link
Copy Markdown
Member Author

Nobody spoke up against this on typing-sig, time to merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood reviewed Jun 13, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood reviewed Jun 13, 2023
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra and others added 3 commits June 13, 2023 19:37
@JelleZijlstra @AlexWaygood
Apply suggestions from code review
fc4eb5d 
Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into protoattrs
7e8636a
@JelleZijlstra @AlexWaygood
Update Lib/typing.py
8b31c81 
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood approved these changes Jun 14, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to merge, in my opinion!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
JelleZijlstra merged commit fc8037d into python:main Jun 14, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 14, 2023
@JelleZijlstra
JelleZijlstra deleted the protoattrs branch June 14, 2023 12:43
@JelleZijlstra
JelleZijlstra restored the protoattrs branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JelleZijlstra @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.