GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104786: Remove kwargs-based TypedDict creation by tomasr8 · Pull Request #104891 · python/cpython

Conversation

@tomasr8

@tomasr8 tomasr8 commented May 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Not sure if/how I should update the docs:

cpython/Doc/library/typing.rst

Lines 1783 to 1785 in c90a862

.. deprecated-removed:: 3.11 3.13
The keyword-argument syntax is deprecated in 3.11 and will be removed
in 3.13. It may also be unsupported by static type checkers.

  • Issue: Remove kwargs-based TypedDict creation #104786

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tomasr8 added 2 commits May 24, 2023 20:37
@tomasr8
Remove kwargs-based TypedDict creation
bfbbc29
@tomasr8
Add news entry
bbbbfa9
@tomasr8
tomasr8 requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners May 24, 2023 19:33
@bedevere-bot bedevere-bot added the awaiting review label May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Remove kwargs-based TypedDict creation #104786
Closed
AlexWaygood
AlexWaygood reviewed May 24, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Could you also add a note to https://github.com/python/cpython/blob/main/Doc/whatsnew/3.13.rst#removed?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tomasr8 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@AlexWaygood

AlexWaygood commented May 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Not sure if/how I should update the docs:

I would remove the existing deprecated-removed note, and add something like:

.. versionchanged:: 3.13
   Removed support for the keyword-argument method of creating ``TypeDict``\s.
tomasr8 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tomasr8 added 2 commits May 24, 2023 21:47
@tomasr8
Update docs
31dde58
@tomasr8
Update whatsnew
6d1fa5e
AlexWaygood
AlexWaygood reviewed May 24, 2023
View reviewed changes
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood reviewed May 24, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8 @AlexWaygood
Update Doc/whatsnew/3.13.rst
6d2ae81 
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood reviewed May 24, 2023
View reviewed changes
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8
Update docs
b8f07d0
JelleZijlstra
JelleZijlstra reviewed May 24, 2023
View reviewed changes
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood mentioned this pull request May 25, 2023
Remove deprecated keyword argument syntax for constructing typing.TypedDict types #104938
Closed
tomasr8 added 2 commits May 25, 2023 21:27
@tomasr8
Remove reference to pep526
ab2cdda
@tomasr8
Merge branch 'main' into typeddict-kwargs-removal
41606de
AlexWaygood
AlexWaygood reviewed May 25, 2023
View reviewed changes
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood reviewed May 25, 2023
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
tomasr8 and others added 2 commits May 25, 2023 21:37
@tomasr8 @AlexWaygood
Improve wording
7dae0e7 
Co-authored-by: Alex Waygood <[email protected]>
@tomasr8
Remove mention of Python 3.6
eb94f7b
AlexWaygood
AlexWaygood reviewed May 25, 2023
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes May 25, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks @tomasr8!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 25, 2023
@AlexWaygood
AlexWaygood requested a review from JelleZijlstra May 25, 2023 20:12
JelleZijlstra
JelleZijlstra approved these changes May 25, 2023
View reviewed changes
@AlexWaygood
AlexWaygood merged commit fea8632 into python:main May 25, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 25, 2023
@tomasr8
tomasr8 deleted the typeddict-kwargs-removal branch May 25, 2023 20:18
@tomasr8

tomasr8 commented May 25, 2023

Copy link
Copy Markdown
Member Author

Thanks for the reviews!
AlexWaygood and JelleZijlstra reacted with rocket emoji
All reactions
  • 🚀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8 tomasr8 mentioned this pull request May 25, 2023
Remove mentions of old Python versions in typing.NamedTuple docstring #104943
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request May 27, 2023
Tests are broken on 3.13 due to TypedDict kwargs removal python/typing_extensions#204
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tomasr8 @AlexWaygood @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.