GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104773: PEP 594: Remove the nis module by vstinner · Pull Request #104897 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 24, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: PEP 594: Remove stdlib modules scheduled for deletion in Python 3.13 #104773

📚 Documentation preview 📚: https://cpython-previews--104897.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-104773: PEP 594: Remove the nis module
dbc4742
@vstinner
vstinner requested review from corona10 and erlend-aasland as code owners May 24, 2023 21:19
@bedevere-bot bedevere-bot added the awaiting core review label May 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
PEP 594: Remove stdlib modules scheduled for deletion in Python 3.13 #104773
Closed
19 tasks done
@hugovk

hugovk commented May 24, 2023

Copy link
Copy Markdown
Member

Some extra nismodule / libnsl bits to remove?

Tools/c-analyzer/cpython/ignored.tsv
285:Modules/nismodule.c  -       TIMEOUT -
286:Modules/nismodule.c  -       aliases -

Tools/c-analyzer/cpython/_parser.py
123:Modules/nismodule.c  /usr/include/tirpc

Tools/c-analyzer/cpython/globals-to-fix.tsv
458:Modules/nismodule.c  nisproc_maplist_2       res     -

PC/pyconfig.h
679:#define HAVE_LIBNSL 1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner requested a review from a team as a code owner May 24, 2023 21:31
@vstinner
Remove more references to nsl library, NIS and nismodule
3f25903
@vstinner
vstinner force-pushed the remove_nis branch from 4530100 to 3f25903 Compare May 24, 2023 21:31
@vstinner

vstinner commented May 24, 2023

Copy link
Copy Markdown
Member Author

Some extra nismodule / libnsl bits to remove?

Well spotted: removed as well.

For now, I prefer to keep this code in configure.ac, since I don't know its purpose and I cannot test a change on Solaris:

$ git grep -B1 -A1 '\<nsl\>'
configure.ac-# Most SVR4 platforms (e.g. Solaris) need -lsocket and -lnsl.
configure.ac:AC_CHECK_LIB(nsl, t_open, [LIBS="-lnsl $LIBS"]) # SVR4
configure.ac-AC_CHECK_LIB(socket, socket, [LIBS="-lsocket $LIBS"], [], $LIBS) # SVR4 sockets
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Add a NEWS entry
47f6640
hugovk
hugovk approved these changes May 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 24, 2023
@vstinner
vstinner merged commit 17e1fe0 into python:main May 24, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 24, 2023
@vstinner
vstinner deleted the remove_nis branch May 24, 2023 22:08
@Ahajha Ahajha mentioned this pull request Nov 29, 2024
cpython: add 3.13.1 conan-io/conan-center-index#25536
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @hugovk @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.