GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] gh-102153: Start stripping C0 control and space chars in `urlsp… by ngie-eign · Pull Request #104918 · python/cpython

Conversation

@ngie-eign

@ngie-eign ngie-eign commented May 25, 2023

Copy link
Copy Markdown
Contributor

…lit`

gh-102153: Start stripping C0 control and space chars in urlsplit (GH-102508)

urllib.parse.urlsplit has already been respecting the WHATWG spec a bit GH-25595.

This adds more sanitizing to respect the "Remove any leading C0 control or space from input" rule in response to CVE-2023-24329.

I simplified the docs by eliding the state of the world explanatory paragraph in this security release only backport. (people will see that in the mainline /3/ docs)

PR Note

This is a manual back port of the fix originally pushed to main as 2f630e1.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting review label May 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 25, 2023
urllib.parse space handling CVE-2023-24329 appears unfixed #102153
Closed
@ngie-eign
ngie-eign force-pushed the 3.8-CVE-2023-24329 branch from 8ac91e7 to 9048acb Compare May 25, 2023 04:18
@ngie-eign @illia-v @gpshead
[3.8] pythongh-102153: Start stripping C0 control and space chars in …
737be53 
…`urlsplit`

pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)

`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bit pythonGH-25595.

This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).

I simplified the docs by eliding the state of the world explanatory
paragraph in this security release only backport.  (people will see
that in the mainline /3/ docs)

Co-authored-by: Illia Volochii <[email protected]>
Co-authored-by: Gregory P. Smith [Google] <[email protected]>
Co-authored-by: Enji Cooper <[email protected]>
@ngie-eign
ngie-eign force-pushed the 3.8-CVE-2023-24329 branch from 9048acb to 737be53 Compare May 25, 2023 04:20
@blurb-it
📜🤖 Added by blurb_it.
f39f666
@ned-deily

ned-deily commented Jun 4, 2023

Copy link
Copy Markdown
Member

Thanks for the PR. However, a backport to 3.8 for this issue already exists as pending PR #104895.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily ned-deily closed this Jun 4, 2023
@ngie-eign
ngie-eign deleted the 3.8-CVE-2023-24329 branch June 6, 2023 00:09
@ngie-eign

ngie-eign commented Jun 6, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the PR. However, a backport to 3.8 for this issue already exists as pending PR #104895.

Wonderful -- thank you for the heads up!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ngie-eign @ned-deily @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.