GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104773: PEP 594: Remove the aifc module by vstinner · Pull Request #104933 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 25, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: PEP 594: Remove stdlib modules scheduled for deletion in Python 3.13 #104773

📚 Documentation preview 📚: https://cpython-previews--104933.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-104773: PEP 594: Remove the aifc module
60ebff7
@bedevere-bot bedevere-bot added the awaiting core review label May 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 25, 2023
PEP 594: Remove stdlib modules scheduled for deletion in Python 3.13 #104773
Closed
19 tasks done
@vstinner

vstinner commented May 25, 2023

Copy link
Copy Markdown
Member Author

Please see the PEP 594 section about aifc:

A user disclosed that the post production film industry makes heavy use of the AIFC file format. The usage of the aifc module in closed source and internal software was unknown prior to the first posting of this PEP. This may be a compelling argument to keep the aifc module in the standard library. The file format is stable and the module does not require much maintenance. The strategic benefits for Python may outmatch the burden.

PEP 594 got accepted, so I understood that the Steering Council took these arguments in account and is fine with removing the aifc module from the Python stdlib.

test_aifc uses the audioop module which prevents the removal of the audioop module. If we want to keep the aifc module but remove audioop ,test_aifc should be rewritten without audioop.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner mentioned this pull request May 25, 2023
gh-104773: PEP 594: Remove the aifc module #104927
Closed
@hugovk

hugovk commented May 25, 2023

Copy link
Copy Markdown
Member

Can we remove these test files as well?

./Lib/test/audiodata/pluck-ulaw.aifc
./Lib/test/audiodata/pluck-alaw.aifc
./Lib/test/Sine-1000Hz-300ms.aif
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented May 25, 2023

Copy link
Copy Markdown
Member Author

Someone else wrote a less complete PR: PR #104927.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
Remove audiodata test files
b026c13
* Remove .aifc and .aiff test files of Lib/test/audiodata/.
* Remove Lib/test/Sine-1000Hz-300ms.aif test file.
@vstinner

vstinner commented May 25, 2023

Copy link
Copy Markdown
Member Author

Can we remove these test files as well?

Right. I remove these test files and a few more.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented May 25, 2023

Copy link
Copy Markdown
Member Author

With this change, test_wave becomes the last user of Lib/test/audiotests.py. I don't think that it's worth it to move the code into Lib/test/test_wave.py. I prefer to leave it as it is for now.

The two remaining AIFC test files are used by test_email:

Lib/test/test_email/data/sndhdr.aifc
Lib/test/test_email/data/sndhdr.aiff
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk approved these changes May 25, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 25, 2023
@vstinner

vstinner commented May 25, 2023

Copy link
Copy Markdown
Member Author

The chunk module is related to AIFF: I wrote PR #104868 to remove it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
Add What's New and Changelog entry
c95194b
@vstinner

vstinner commented May 25, 2023

Copy link
Copy Markdown
Member Author

I added a What's New in Python 3.13 and Changelog entry.

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented May 25, 2023

Copy link
Copy Markdown
Member Author

A user disclosed that the post production film industry makes heavy use of the AIFC file format.

The VFX platform still uses Python 3.10 in 2023 ("CY2023"): https://vfxplatform.com/ Python will be upgraded to Python 3.11 next year ("CY2024 DRAFT").

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit 036da3b into python:main May 25, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 25, 2023
@vstinner
vstinner deleted the remove_aifc branch May 25, 2023 15:20
@vstinner vstinner mentioned this pull request May 30, 2023
wave: Deprecate getmark(), setmark() and getmarkers() methods #105096
Closed
@vstinner

vstinner commented May 30, 2023

Copy link
Copy Markdown
Member Author

See also issue #105096: wave: Deprecate getmark(), setmark() and getmarkers() methods.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @hugovk @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.