GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-104372: Drop the GIL around the vfork() call. (#104782) by gpshead · Pull Request #104958 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented May 26, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

On Linux where the subprocess module can use the vfork syscall for faster spawning, prevent the parent process from blocking other threads by dropping the GIL while it waits for the vfork'ed child process exec outcome. This prevents spawning a binary from a slow filesystem from blocking the rest of the application.

Fixes #104372.

(cherry picked from commit d086792)

  • Issue: subprocess can block all Python threads when using vfork() until the child process exec() succeeds or fails. #104372

📚 Documentation preview 📚: https://cpython-previews--104958.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
pythongh-104372: Drop the GIL around the vfork() call. (python#104782)
75f7969 
On Linux where the `subprocess` module can use the `vfork` syscall for
faster spawning, prevent the parent process from blocking other threads
by dropping the GIL while it waits for the vfork'ed child process `exec`
outcome.  This prevents spawning a binary from a slow filesystem from
blocking the rest of the application.

Fixes python#104372.

(cherry picked from commit d086792)
@bedevere-bot bedevere-bot mentioned this pull request May 26, 2023
subprocess can block all Python threads when using vfork() until the child process exec() succeeds or fails. #104372
Closed
@gpshead gpshead self-assigned this May 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 26, 2023
gh-104372: Drop the GIL around the vfork() call. #104782
Merged
@gpshead

gpshead commented May 30, 2023

Copy link
Copy Markdown
Member Author

I want to let this bake in some 3.12beta releases for a while before applying it to a stable release. thus "draft".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja

hauntsaninja commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

3.12 is now at RC stage; should we merge to 3.11?
gpshead reacted with thumbs up emoji gpshead reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead
gpshead marked this pull request as ready for review September 1, 2023 08:26
@bedevere-bot bedevere-bot added the awaiting core review label Sep 1, 2023
@gpshead
Merge branch '3.11' into backport-d086792-3.11
02ea82a
@gpshead
gpshead enabled auto-merge (squash) September 1, 2023 08:26
@gpshead
gpshead merged commit 6ba1234 into python:3.11 Sep 1, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 1, 2023
@gpshead
gpshead deleted the backport-d086792-3.11 branch September 4, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gpshead @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.