GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-104972: Ensure that line attributes in tokens in the tokenize module are correct (GH-104975) by miss-islington · Pull Request #104982 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 3fdb55c)

Co-authored-by: Pablo Galindo Salgado [email protected]

  • Issue: The lines in tokens from tokenize.generate_tokens incorrectly indicate multiple lines. #104972

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal @miss-islington
pythongh-104972: Ensure that line attributes in tokens in the tokeniz…
25cf9f2 
…e module are correct (pythonGH-104975)

(cherry picked from commit 3fdb55c)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@miss-islington
miss-islington requested a review from terryjreedy as a code owner May 26, 2023 14:46
@bedevere-bot bedevere-bot added the awaiting review label May 26, 2023
This was referenced May 26, 2023
The lines in tokens from tokenize.generate_tokens incorrectly indicate multiple lines. #104972
Closed
gh-104972: Ensure that line attributes in tokens in the tokenize module are correct #104975
Merged
pablogsal
pablogsal approved these changes May 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 26, 2023
@terryjreedy
terryjreedy merged commit 8ca2957 into python:3.12 May 26, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 26, 2023
@miss-islington
miss-islington deleted the backport-3fdb55c-3.12 branch May 26, 2023 15:25
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @pablogsal @terryjreedy @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.