GeezerVison is showing github.com — GH-104898: Revert pathlib os.PathLike registration change. by barneygale · Pull Request #105073 · python/cpython
Conversation
barneygale
commented
May 29, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Subclassing os.PathLike rather than using register() makes initialisation slower, due to the additional __isinstance__ work.
This partially reverts commit bd1b622.
$ ./python -m timeit -s 'from pathlib import PurePath' 'PurePath("a", "b", "c")'
100000 loops, best of 5: 2.12 usec per loop # before
200000 loops, best of 5: 1.69 usec per loop # after
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Subclassing `os.PathLike` rather than using `register()` makes
initialisation slower, due to the additional `__isinstance__` work.
This partially reverts commit bd1b622.
Uh oh!
There was an error while loading. Please reload this page.
|
|
|
|
|
# Subclassing os.PathLike makes isinstance() checks slower,
|
|
|
# which in turn makes Path construction slower. Register instead!
|
|
|
os.PathLike.register(PurePath)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that you can use ABC.register as a class decorator, but I think it would not look better for this case.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
barneygale reacted with thumbs up emoji
Reviewers
merwok
merwok approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.