GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] Enable the ABI check job to publish the expected ABI data by zooba · Pull Request #105088 · python/cpython

Conversation

@zooba

@zooba zooba commented May 30, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
Enable the ABI check job to publish the expected ABI data
83b6e40
@zooba zooba added skip issue skip news labels May 30, 2023
@zooba
zooba requested review from ezio-melotti and hugovk as code owners May 30, 2023 11:42
@bedevere-bot bedevere-bot added the awaiting core review label May 30, 2023
@zooba zooba changed the title Enable the ABI check job to publish the expected ABI data [3.12] Enable the ABI check job to publish the expected ABI data May 30, 2023
@zooba
Simulating a failure - will revert this before merging!
ea1d770
@zooba zooba added the DO-NOT-MERGE label May 30, 2023
@zooba
Try a different simulated failure
74f759d
@zooba

zooba commented May 30, 2023

Copy link
Copy Markdown
Member Author

See https://github.com/python/cpython/actions/runs/5121117083 for a build with an ABI break, but I'm reverting the break now to get back to mergeable state.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Revert simulated breakage
d24da92
@zooba zooba removed the DO-NOT-MERGE label May 30, 2023
@zooba
Filter published file and add simulated breakage
9860e80
@zooba zooba added the DO-NOT-MERGE label May 30, 2023
@AlexWaygood AlexWaygood mentioned this pull request May 30, 2023
[3.12] gh-104799: Move location of type_params AST fields (GH-104828) #104974
Merged
@zooba
Improved message and more drastic breakage for testing
05b0606
@zooba

zooba commented May 30, 2023

Copy link
Copy Markdown
Member Author

New demo build with added note to the message (and I'll update the devguide page too once this is merged) https://github.com/python/cpython/actions/runs/5122553620/jobs/9211810623?pr=105088

Just waiting to see the uploaded files
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba added 2 commits May 30, 2023 15:54
@zooba
Update ABI data from build
1cfe7f7
@zooba
Merge remote-tracking branch 'cpython/3.12' into abiupdates-3.12
ab50ca0
@zooba zooba added needs backport to 3.11 only security fixes and removed DO-NOT-MERGE labels May 30, 2023
@zooba
zooba merged commit 4e7d41f into python:3.12 May 30, 2023
@zooba
zooba deleted the abiupdates-3.12 branch May 30, 2023 16:32
@zooba zooba removed the needs backport to 3.11 only security fixes label May 30, 2023
@Yhg1s Yhg1s mentioned this pull request Jun 1, 2023
[3.12] gh-105020: Share tp_bases and tp_mro Between Interpreters For All Static Builtin Types (gh-105115) #105124
Merged
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@zooba @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.