GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105096: Deprecate wave getmarkers() method by vstinner · Pull Request #105098 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 30, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

wave: Deprecate the getmark(), setmark() and getmarkers() methods of the Wave_read and Wave_write classes. They will be removed in Python 3.15.

  • Issue: wave: Deprecate getmark(), setmark() and getmarkers() methods #105096

📚 Documentation preview 📚: https://cpython-previews--105098.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label May 30, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 30, 2023
wave: Deprecate getmark(), setmark() and getmarkers() methods #105096
Closed
@vstinner

vstinner commented May 30, 2023

Copy link
Copy Markdown
Member Author

cc @hugovk
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner force-pushed the deprecate_wave branch from 7f4c3e5 to 495a8d3 Compare May 30, 2023 15:54
hugovk
hugovk reviewed May 30, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request May 31, 2023
gh-105096: Reformat wave documentation #105136
Merged
@vstinner
pythongh-105096: Deprecate wave getmarkers() method
aa6cc51 
wave: Deprecate the getmark(), setmark() and getmarkers() methods of
the Wave_read and Wave_write classes. They will be removed in Python
3.15.
@vstinner
vstinner force-pushed the deprecate_wave branch from 495a8d3 to aa6cc51 Compare May 31, 2023 11:45
@vstinner

vstinner commented May 31, 2023

Copy link
Copy Markdown
Member Author

I wrote PR #105136 to add .. class:: markups.

It got merged, so I rebased this PR on top of it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes May 31, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 31, 2023
@vstinner
vstinner enabled auto-merge (squash) May 31, 2023 12:04
@vstinner
vstinner merged commit 03ad662 into python:main May 31, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 31, 2023
@vstinner
vstinner deleted the deprecate_wave branch May 31, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @hugovk @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.