GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-89886: Properly quote Autoconf macro arguments (#105062) by erlend-aasland · Pull Request #105118 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 30, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Autoconf 2.70 macros are picky about argument quotation.

  • Issue: Improve and simplify configure.ac checks #89886

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@erlend-aasland
[3.12] pythongh-89886: Properly quote Autoconf macro arguments (pytho…
f8f2982
…n#105062)

Autoconf 2.70 macros are picky about argument quotation.
@erlend-aasland
erlend-aasland requested a review from corona10 as a code owner May 30, 2023 21:30
@bedevere-bot bedevere-bot added the awaiting core review label May 30, 2023
This was referenced May 30, 2023
Improve and simplify configure.ac checks #89886
Closed
gh-89886: Properly quote Autoconf macro arguments #105062
Merged
@bedevere-bot bedevere-bot added the skip news label May 30, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 30, 2023 21:31
@erlend-aasland
erlend-aasland merged commit af7b55d into python:3.12 May 30, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 30, 2023
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
@erlend-aasland
erlend-aasland deleted the 3.12-backport-autoconf-macro-quotes branch July 4, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.