GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103142: Update error codes, multissltests, and CI workflows for OpenSSL 1.1.1u, 3.0.9, and 3.1.1. by ned-deily · Pull Request #105129 · python/cpython

Conversation

@ned-deily

@ned-deily ned-deily commented May 31, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Update OpenSSL used in binary releases per CVE-2023-0464 #103142

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ned-deily
Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.…
c64594e
…1.1.
@ned-deily ned-deily added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 31, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 31, 2023
@ned-deily ned-deily changed the title Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1. gh-103142: Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1. May 31, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 31, 2023
Update OpenSSL used in binary releases per CVE-2023-0464 #103142
Closed
@ned-deily
Update OpenSSL versions used in GitHub workflows.
d79ba76
@ned-deily
ned-deily requested review from ezio-melotti and hugovk as code owners May 31, 2023 04:37
@ned-deily
Update SSLErrorLibrary for 1.1.1 and 3.x.
b50fe17
@ned-deily ned-deily changed the title gh-103142: Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1. gh-103142: Update error codes, multissltests, and CI workflows for OpenSSL 1.1.1u, 3.0.9, and 3.1.1. May 31, 2023
@ned-deily ned-deily added needs backport to 3.7 release-blocker labels May 31, 2023
@ned-deily
ned-deily requested review from ambv and gpshead May 31, 2023 19:48
@gpshead gpshead mentioned this pull request May 31, 2023
gh-103142: Upgrade binary builds and CI to OpenSSL 1.1.1u #105174
Merged
@gpshead

gpshead commented May 31, 2023

Copy link
Copy Markdown
Member

There are PCbuild/ and .azure-pipelines/ references that also need updating (see my draft #105174 which I was just basing off of what I blindly did for the previous update in #101727). But lets go forward with your PR here just adding those bits. I don't think I ever looked at that make_ssl_data.py generated .h file of string/constant definitions.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gpshead

gpshead commented May 31, 2023

Copy link
Copy Markdown
Member

some windows versions may need to wait on someone uploading an openssl-bin-1.1.1u artifact somewhere? based on #101727 comments @zooba did that last time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gpshead
gpshead requested a review from zooba May 31, 2023 22:22
@zooba

zooba commented May 31, 2023

Copy link
Copy Markdown
Member

I've posted the binaries for Windows. They are codesigned, so have to be done by someone with release team access.

I don't think I ever looked at that make_ssl_data.py generated .h file of string/constant definitions.

I thought there was an open issue/PR to replace this file? As we should have access to OpenSSL's copies of this data. Guess it isn't merged yet...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gpshead

gpshead commented Jun 1, 2023

Copy link
Copy Markdown
Member

I updated my PR #105174 to have the additional bits that this touched plus a tweak to the _ssl_data .h file regeneration. If CI and buildbots are happy with it, I'll merge mine and generate the backport PRs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gpshead
gpshead marked this pull request as draft June 1, 2023 03:32
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 1, 2023
@ned-deily

ned-deily commented Jun 1, 2023

Copy link
Copy Markdown
Member Author

Closed in favor of #105174

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily ned-deily closed this Jun 1, 2023
@gpshead

gpshead commented Jun 1, 2023

Copy link
Copy Markdown
Member

woo, thanks Ned! (we were both considering this, when I created my PR I hadn't yet looked to see if someone else had taken this on. No worries from my end about the duplicate work collision, it's good to have eyeballs on the issue).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily
ned-deily deleted the gh-103142-multissltests branch June 6, 2023 18:49
@ambv ambv removed needs backport to 3.8 needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@ambv ambv Awaiting requested review from ambv
@zooba zooba Awaiting requested review from zooba
@picnixz picnixz Awaiting requested review from picnixz picnixz will be requested when the pull request is marked ready for review picnixz is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz will be requested when the pull request is marked ready for review webknjaz is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner
@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee JacobCoffee will be requested when the pull request is marked ready for review JacobCoffee is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland will be requested when the pull request is marked ready for review StanFromIreland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release-blocker

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ned-deily @gpshead @zooba @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.