GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-35214: Fix OOB memory access in unicode escape parser (GH-10506) by miss-islington · Pull Request #10522 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 13, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Discovered using clang's MemorySanitizer when it ran python3's
test_fstring test_misformed_unicode_character_name.

An msan build will fail by simply executing: ./python -c 'u"\N"'
(cherry picked from commit 746b2d3)

Co-authored-by: Gregory P. Smith [email protected]

https://bugs.python.org/issue35214

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead @miss-islington
bpo-35214: Fix OOB memory access in unicode escape parser (pythonGH-1…
266bb03 
…0506)

Discovered using clang's MemorySanitizer when it ran python3's
test_fstring test_misformed_unicode_character_name.

An msan build will fail by simply executing: ./python -c 'u"\N"'
(cherry picked from commit 746b2d3)

Co-authored-by: Gregory P. Smith <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 13, 2018
@bedevere-bot bedevere-bot mentioned this pull request Nov 13, 2018
bpo-35214: Fix OOB memory access in unicode escape parser #10506
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Nov 13, 2018
gpshead
gpshead approved these changes Nov 13, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 13, 2018
@gpshead gpshead added awaiting review 🤖 automerge and removed awaiting merge labels Nov 13, 2018
@miss-islington

miss-islington commented Nov 13, 2018

Copy link
Copy Markdown
Contributor Author

@gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Nov 13, 2018

Copy link
Copy Markdown
Contributor Author

@gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta

Mariatta commented Nov 14, 2018

Copy link
Copy Markdown
Member

@gpshead any reason you removed the "awaiting review" label? That is the reason this PR was not automerged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Nov 14, 2018

Copy link
Copy Markdown
Member

The label changes look like a race condition between bedevere-bot and myself, it made the +merge -review change at the same time i had the page open and manually selected +automerge. I suspect github's UI RPC call for this probably sends the whole label list rather than just the deltas over what the user thought was there?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead added awaiting merge and removed awaiting review labels Nov 14, 2018
@miss-islington
miss-islington merged commit 9fbcb14 into python:3.7 Nov 14, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 14, 2018
@miss-islington
miss-islington deleted the backport-746b2d3-3.7 branch November 14, 2018 00:39
@gpshead gpshead mentioned this pull request Aug 22, 2023
Get the test suite passing with clang Memory Sanitizer enabled #79395
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @Mariatta @gpshead @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.