GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105310: add decorator to skip rerunning tests by sunmy2019 · Pull Request #105311 · python/cpython

Conversation

@sunmy2019

@sunmy2019 sunmy2019 commented Jun 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Personally, I am not satisfied with the test case added in test_support.py, but I can not figure out something better.

  • Issue: Allow test cases to skip rerun #105310

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sunmy2019
add skip_rerun decorator for tests
23d9fb5
@sunmy2019
sunmy2019 requested a review from erlend-aasland June 5, 2023 12:26
@bedevere-bot bedevere-bot added the awaiting review label Jun 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 5, 2023
Allow test cases to skip rerun #105310
Closed
erlend-aasland
erlend-aasland requested changes Jun 5, 2023
View reviewed changes
Comment thread Lib/test/support/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Jun 5, 2023
@bedevere-bot

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sunmy2019
sunmy2019 commented Jun 5, 2023
View reviewed changes
Comment thread Lib/test/support/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
sunmy2019
sunmy2019 commented Jun 5, 2023
View reviewed changes
Comment thread Lib/test/support/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sunmy2019
Apply suggestions from code review
32e5050
@sunmy2019

sunmy2019 commented Jun 5, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

I think we need news for this one, right?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jun 5, 2023
@bedevere-bot

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from erlend-aasland June 5, 2023 12:35
@erlend-aasland

erlend-aasland commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

I think we need news for this one, right?

Well, test changes rarely get their own NEWS items. Personally, I would not bother with it. Related: also note that a lot of the test.support methods intentionally lack docs.
sunmy2019 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunmy2019 sunmy2019 added the skip news label Jun 5, 2023
@sunmy2019

sunmy2019 commented Jun 20, 2023

Copy link
Copy Markdown
Member Author

Closed. See #104796 (comment)
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunmy2019 sunmy2019 closed this Jun 20, 2023
@sunmy2019
sunmy2019 deleted the gh-105310 branch June 23, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting change review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sunmy2019 @bedevere-bot @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.