GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-70303: Emit FutureWarning when pathlib glob pattern ends with `**` by barneygale · Pull Request #105413 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Jun 6, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In a future Python release, patterns with this ending will match both files and directories. Users may add a trailing slash to remove the warning and match only directories.

  • Issue: pathlib.glob('**') returns only directories #70303

📚 Documentation preview 📚: https://cpython-previews--105413.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-70303: Emit FutureWarning when pathlib glob pattern ends wit…
f63bca9 
…h `**`.

In a future Python release, patterns with this ending will match both files
and directories. Users may add a trailing slash to remove the warning.
@barneygale barneygale added the topic-pathlib label Jun 6, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jun 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 6, 2023
pathlib.glob('**') returns only directories #70303
Closed
@barneygale
Fix handling of patterns ending **
d1a1716
@barneygale barneygale changed the title GH-70303: Emit FutureWarning when pathlib glob pattern ends with **. GH-70303: Match files and directories in pathlib.Path.glob() pattern ending ** Jun 18, 2023
@barneygale barneygale changed the title GH-70303: Match files and directories in pathlib.Path.glob() pattern ending ** GH-70303: Match files and directories with pathlib.Path.glob() pattern ending ** Jun 18, 2023
barneygale added 3 commits June 18, 2023 18:25
@barneygale
Add whatsnew entry; fix news typo.
22be3a6
@barneygale
Revert "Add whatsnew entry; fix news typo."
91bbce1 
This reverts commit 22be3a6.
@barneygale
Revert "Fix handling of patterns ending **"
0566137 
This reverts commit d1a1716.
@barneygale barneygale changed the title GH-70303: Match files and directories with pathlib.Path.glob() pattern ending ** GH-70303: Emit FutureWarning when pathlib glob pattern ends with ** Jun 20, 2023
@barneygale barneygale mentioned this pull request Jul 14, 2023
Glob behavior is inconsistent across libraries #106747
Closed
@barneygale
barneygale requested a review from jaraco July 26, 2023 20:44
jaraco
jaraco approved these changes Aug 4, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 4, 2023
@barneygale
Merge branch 'main' into pythongh-70303-glob-recursive-no-trailing-slash
148b32e
@barneygale
barneygale enabled auto-merge (squash) August 4, 2023 22:43
@barneygale
Do-nothing commit to try to wake GitHub up :/
a7f47aa
@barneygale
barneygale merged commit ec0a0d2 into python:main Aug 4, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 4, 2023
@barneygale barneygale mentioned this pull request Jan 28, 2024
GH-70303: Make pathlib.Path.glob('**') return both files and directories #114684
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@barneygale @jaraco @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.