GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-105497: [Enum] Fix Flag inversion when alias/mask members exist. (GH-105542) by miss-islington · Pull Request #105572 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

When inverting a Flag member (or boundary STRICT), only consider other canonical flags; when inverting an IntFlag member (or boundary KEEP), also consider aliases.
(cherry picked from commit 59f009e)

Co-authored-by: Ethan Furman [email protected]

  • Issue: 3.11.4: ValueError when inverting enum.Flag member with mask member #105497

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ethanfurman @miss-islington
pythongh-105497: [Enum] Fix Flag inversion when alias/mask members ex…
fc21528
…ist. (pythonGH-105542)

When inverting a Flag member (or boundary STRICT), only consider other canonical flags; when inverting an IntFlag member (or boundary KEEP), also consider aliases.
(cherry picked from commit 59f009e)

Co-authored-by: Ethan Furman <[email protected]>
@miss-islington
miss-islington requested a review from ethanfurman as a code owner June 9, 2023 15:57
@bedevere-bot bedevere-bot added the awaiting review label Jun 9, 2023
This was referenced Jun 9, 2023
3.11.4: ValueError when inverting enum.Flag member with mask member #105497
Closed
gh-105497: [Enum] Fix flag inversion when alias/mask members exist. #105542
Merged
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Jun 9, 2023
ethanfurman
ethanfurman approved these changes Jun 9, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 9, 2023
@ambv
ambv merged commit 74d84cf into python:3.12 Jul 5, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 5, 2023
@miss-islington
miss-islington deleted the backport-59f009e-3.12 branch July 5, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @ethanfurman @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.