GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-105375: Harden _datetime initialisation (GH-105604) by miss-islington · Pull Request #105645 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 11, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Improve error handling so init bails on the first exception.
(cherry picked from commit 16d4968)

Co-authored-by: Erlend E. Aasland [email protected]

  • Issue: Incorrect error handling for APIs that can raise exceptions #105375

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland @miss-islington
pythongh-105375: Harden _datetime initialisation (pythonGH-105604)
8e1438e 
Improve error handling so init bails on the first exception.
(cherry picked from commit 16d4968)

Co-authored-by: Erlend E. Aasland <[email protected]>
@miss-islington
miss-islington requested review from abalkin and pganssle as code owners June 11, 2023 10:03
@bedevere-bot bedevere-bot added the awaiting review label Jun 11, 2023
This was referenced Jun 11, 2023
Incorrect error handling for APIs that can raise exceptions #105375
Closed
gh-105375: Harden _datetime initialisation #105604
Merged
erlend-aasland
erlend-aasland approved these changes Jun 11, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 11, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) June 11, 2023 10:04
@erlend-aasland
erlend-aasland merged commit 36ecbc3 into python:3.12 Jun 11, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 11, 2023
@miss-islington
miss-islington deleted the backport-16d4968-3.12 branch June 11, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.